Repository navigation
Conversation
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (2 classes)
ExecutionStrategy — method details
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with a query registered in
InMemoryPersistedQueryCachefor an id, and a request that sends that id together with its own query text:getPersistedQueryDocumentAsyncreadsexecutionInput.getQuery()first and only falls back toknownQuerieswhen that text is null, empty or the APQ marker. so on a cache miss the request's text is what gets compiled and stored under the id, and every later caller that sends only the id is served that document.ApolloPersistedQuerySupportis not exposed becausepersistedQueryIdIsInvalidrejects text whose sha256 differs from the id, but the basePersistedQuerySupportreturns false there, so with any other id scheme a client can replace a server registered query by sending its own text next to a known id. the custom cache inApolloPersistedQuerySupportTest("will use query hash in preference to query text") already treats the registered text as authoritative; the in memory cache did the opposite.look the id up in
knownQueriesfirst and only register text from the execution input for an id that is not known. the apollo flow is unchanged, since text that passes the hash check is the registered text anyway.