Repository navigation
Preserve DataFetcherResult extensions on subscription events - #4476
Open
kalayciburak wants to merge 1 commit into
Open
kalayciburak wants to merge 1 commit into
kalayciburak wants to merge 1 commit into
Conversation
Copy extensions from an emitted DataFetcherResult onto that event's ExecutionResult instead of dropping them when wrapping the root field. Fixes graphql-java#4475
Contributor
Test ReportTest Results
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4475.
When a subscription publisher emits a
DataFetcherResultthat carriesextensions, those values never appear on the corresponding eventExecutionResult.unboxPossibleDataFetcherResultrecords them on the sharedExtensionsBuilder, butexecuteSubscriptionEventbuilds each event result with only data and errors, andwrapWithRootFieldNamethen reconstructs the result without copying extensions.Query execution already merges
ExtensionsBuilderinto the overall result. Subscription events are independent results, so the extensions from that event'sDataFetcherResultneed to travel with that event.Change
DataFetcherResult.getExtensions()from the event payload.ExecutionResultImpl.Test plan
Executed locally:
./gradlew test --tests graphql.execution.SubscriptionExecutionStrategyTest— 24 tests, 1 failed (extensions=nullon the new test)./gradlew test --tests graphql.execution.DataFetcherResultTest --tests graphql.extensions.ExtensionsBuilderTest— 36/0