JSpecify gigantic wave 4#4301
Open
dondonz wants to merge 194 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
# Conflicts: # src/test/groovy/graphql/archunit/JSpecifyAnnotationsCheck.groovy
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (7 classes)
AstTransformer — method details
Parser.1 — method details
SchemaPrinter — method details
|
TreeParallelTransformer only set List.class as a context var but never NodeAdapter.class. After JSpecify annotations wrapped getVar() calls with assertNotNull(), this caused test failures in TreeParallelTransformerTest and AstTransformerTest. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dondonz
commented
Mar 7, 2026
| public void compute() { | ||
| currentContext.setPhase(TraverserContext.Phase.ENTER); | ||
| currentContext.setVar(List.class, myZippers); | ||
| currentContext.setVar(NodeAdapter.class, nodeAdapter); |
Member
Author
There was a problem hiding this comment.
Another interesting bugfix surfaced by JSpecify
# Conflicts: # .claude/commands/jspecify-annotate.md # src/main/java/graphql/execution/ExecutionContext.java # src/main/java/graphql/introspection/GoodFaithIntrospection.java # src/main/java/graphql/normalized/ExecutableNormalizedOperation.java # src/test/groovy/graphql/archunit/JSpecifyAnnotationsCheck.groovy
# Conflicts: # src/main/java/graphql/execution/directives/QueryAppliedDirectiveArgument.java # src/main/java/graphql/execution/preparsed/PreparsedDocumentEntry.java # src/main/java/graphql/util/Anonymizer.java
Removes 31 classes from JSPECIFY_EXEMPTION_LIST in JSpecifyAnnotationsCheck.groovy that have already been annotated with @NullMarked/@NullUnmarked across the wave 4 work. The "exempted classes should not be annotated" archunit test was failing because these classes were both exempt and annotated. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
# Conflicts: # src/main/java/graphql/language/AstSignature.java # src/main/java/graphql/language/VariableDefinition.java
Member
Author
|
Note this is only failing the coverage test for now |
dondonz
commented
May 24, 2026
dondonz
commented
May 24, 2026
| return objectTypeDefinition.build(); | ||
| } | ||
|
|
||
| @SuppressWarnings("NullAway") |
Member
Author
There was a problem hiding this comment.
Should remove these NullAway suppress warnings
…ql-java into claude/jspecify-wave4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over 120 new JSpecify annotated classes in this PR.
This is ready for review.
A short note - code coverage checks were introduced alongside JSpecify work. This work does reduce coverage but I am planning to reset the baseline when this PR gets merged in
There are only ~10 classes left to annotate after this PR.