Add JSpecify annotations to 10 language package classes by Copilot · Pull Request #4219 · graphql-java/graphql-java

Copilot · 2026-01-25T06:36:27Z

Annotates 10 classes in graphql.language with JSpecify nullability markers per the established pattern.

Classes Annotated

Interfaces:

ImplementingTypeDefinition - @NullMarked
NodeDirectivesBuilder - @NullMarked

Classes with Builders:

InlineFragment - @NullMarked class, @NullUnmarked Builder
InputObjectTypeDefinition + Extension - @NullMarked classes, @NullUnmarked Builders
InputValueDefinition - @NullMarked class, @NullUnmarked Builder
InterfaceTypeDefinition + Extension - @NullMarked classes, @NullUnmarked Builders
ListType - @NullMarked class, @NullUnmarked Builder

Other:

NodeParentTree - @NullMarked

Nullability Decisions

Fields marked @Nullable based on GraphQL spec and usage analysis:

InlineFragment.typeCondition - Inline fragments can omit type conditions (spec allows bare ... { field })
InputValueDefinition.defaultValue - Default values are optional
NodeParentTree.parent - Root nodes have no parent
All Description parameters - Descriptions are optional in GraphQL SDL
All SourceLocation parameters - Inherited from AbstractNode pattern

Technical Fixes

deepCopy methods: Added assertNotNull calls where AbstractNode.deepCopy() returns nullable types but target constructors expect non-null:

public InlineFragment deepCopy() {
    return new InlineFragment(
            deepCopy(typeCondition),  // nullable is fine
            assertNotNull(deepCopy(directives.getDirectives()), "directives cannot be null"),
            assertNotNull(deepCopy(selectionSet), "selectionSet cannot be null"),
            // ...
    );
}

InlineFragment constructor: Provides default SelectionSet instead of null since selection sets are required.

Anonymizer: Added null check for typeCondition before dereferencing in visitInlineFragment.

Removes all 10 classes from JSpecify exemption list.

Original prompt

Task

Add JSpecify annotations to the following 10 classes in the graphql.language package, following the established JSpecify annotation pattern documented in .claude/commands/jspecify-annotate.md.

Classes to annotate

graphql.language.ImplementingTypeDefinition

graphql.language.InlineFragment

graphql.language.InputObjectTypeDefinition

graphql.language.InputObjectTypeExtensionDefinition

graphql.language.InputValueDefinition

graphql.language.InterfaceTypeDefinition

graphql.language.InterfaceTypeExtensionDefinition

graphql.language.ListType

graphql.language.NodeDirectivesBuilder

graphql.language.NodeParentTree

Instructions

Follow the JSpecify annotation process documented in .claude/commands/jspecify-annotate.md:

Set each class to be @NullMarked at the class level

Remove all redundant @NonNull annotations that IntelliJ may have added

Check Javadoc for @param tags mentioning "null", "nullable", "may be null"

Check Javadoc @return tags mentioning "null", "optional", "if available"

Inspect method implementations that return null or check for null

Consider GraphQL specification details when determining nullability

For Builder static classes, label them @NullUnmarked and no further annotations needed

Validation

After making changes, run the NullAway compile check:
./gradlew compileJava
If you find NullAway errors, make the smallest possible change to fix them. You can use assertNotNull with a message if needed.

Cleanup

Remove each completed class from the exemption list in src/test/groovy/graphql/archunit/JSpecifyAnnotationsCheck.groovy

Delete all unused imports from the classes you've annotated

Do not make spacing or formatting changes - only make minimal changes necessary for the annotations

Reference

Look at existing annotated classes like IntValue.java, StringValue.java, AbstractNode.java in the same package for reference patterns.

This pull request was created from Copilot chat.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: dondonz <13839920+dondonz@users.noreply.github.com>

- Added @NullMarked to ImplementingTypeDefinition interface - Added @NullMarked to InlineFragment with @nullable typeCondition - Added @NullMarked to InputObjectTypeDefinition with @NullUnmarked Builder - Added @NullMarked to InputObjectTypeExtensionDefinition with @NullUnmarked Builder - Added @NullMarked to InputValueDefinition with @nullable defaultValue - Added @NullMarked to InterfaceTypeDefinition with @NullUnmarked Builder - Added @NullMarked to InterfaceTypeExtensionDefinition with @NullUnmarked Builder - Added @NullMarked to ListType with @NullUnmarked Builder - Added @NullMarked to NodeDirectivesBuilder interface - Added @NullMarked to NodeParentTree with @nullable parent - Fixed deepCopy methods with assertNotNull for non-null fields - Fixed InlineFragment constructor to provide default SelectionSet - Fixed Anonymizer to handle nullable typeCondition - Removed completed classes from JSpecify exemption list Co-authored-by: dondonz <13839920+dondonz@users.noreply.github.com>

github-actions · 2026-02-20T21:16:39Z

Test Results

335 files ±0 335 suites ±0 5m 4s ⏱️ -1s
5 376 tests +5 5 367 ✅ +4 9 💤 +1 0 ❌ ±0
5 465 runs +5 5 456 ✅ +4 9 💤 +1 0 ❌ ±0

Results for commit 0fb0195. ± Comparison against base commit 89b4446.

This pull request removes 449 and adds 430 tests. Note that renamed tests count towards both.

	?

	, expected: combo-\"\\\b\f\n\r\t, #4]
                __schema { types { fields { args { type { name fields { name }}}}}}
                __schema { types { fields { type { name fields { name }}}}}
                __schema { types { inputFields { type { inputFields { name }}}}}
                __schema { types { interfaces { fields { type { interfaces { name } } } } } }
                __schema { types { name} }
                __type(name : "t") { name }
                a1: __schema { types { name} }
                a1: __type(name : "t") { name }
…

graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure23@75de29c0 delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure24@fc807c1 delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure25@296e281a delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure20@6dcc40f5 delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure21@2b680207 delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure22@70887727 delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure3@730f9695 delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1, #0]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure4@146dcfe6 delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1 arg2, #1]
graphql.AssertTest ‑ assertNotNull with different number of  error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure5@1b1f5012 delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1 arg2 arg3, #2]
graphql.AssertTest ‑ assertNotNull with different number of error args with non null does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_6prov0_closure6@51c959a4 delegate=inaccessible owner=inaccessible thisObject=inaccessible resolveStrategy=inaccessible directive=inaccessible parameterTypes=inaccessible maximumNumberOfParameters=inaccessible bcw=inaccessible thisType=inaccessible>, expectedMessage: error arg1, #0]
…

This pull request skips 1 test.

graphql.schema.fetching.LambdaFetchingSupportTest ‑ different class loaders induce certain behaviours

♻️ This comment has been updated with latest results.

dondonz · 2026-02-21T05:51:19Z

-    public InlineFragment(TypeName typeCondition) {
-        this(typeCondition, emptyList(), null, null, emptyList(), IgnoredChars.EMPTY, emptyMap());
+    public InlineFragment(@Nullable TypeName typeCondition) {
+        this(typeCondition, emptyList(), SelectionSet.newSelectionSet().build(), null, emptyList(), IgnoredChars.EMPTY, emptyMap());


This is technically a breaking change, although it's to make this more correct

An inline fragment should not have an empty selection set, as per the specification.

fair ... I think we should not allow null selection set here.

dondonz · 2026-02-21T05:51:52Z

This PR will start enforcing selection sets in inline fragments as not nullable, so this is technically a breaking change, but one that's also a bugfix

Resolve JSpecifyAnnotationsCheck conflict by taking master's exemption list updates. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-21T07:04:11Z

Test Report

Test Results

Java Version	Total	Passed	Failed	Errors	Skipped
Java 11	5708 (±0)	5652 (±0)	0 (±0)	0 (±0)	56 (±0)
Java 17	5708 (±0)	5651 (±0)	0 (±0)	0 (±0)	57 (±0)
Java 21	5708 (±0)	5651 (±0)	0 (±0)	0 (±0)	57 (±0)
Java 25	5708 (±0)	5651 (±0)	0 (±0)	0 (±0)	57 (±0)
jcstress	32 (±0)	32 (±0)	0 (±0)	0 (±0)	0 (±0)
Total	22864 (±0)	22637 (±0)	0 (±0)	0 (±0)	227 (±0)

Code Coverage (Java 25)

Metric	Covered	Missed	Coverage	vs Master
Lines	28777	3121	90.2%	±0.0%
Branches	8355	1507	84.7%	±0.0%
Methods	7698	1222	86.3%	±0.0%

Changed Class Coverage (1 class)

Class	Line	Branch	Method
g.u.Anonymizer $4	-1.8% 🔴	-7.1% 🔴	±0.0%

Anonymizer.4 — method details

Method	Line	Branch
visitInlineFragment	83.3% (-16.7% 🔴)	50.0%

Full HTML report: build artifact jacoco-html-report

Updated: 2026-03-21 08:10:43 UTC

NodeVisitor, NodeVisitorStub, SourceLocation, and Type are already annotated with @NullMarked so they should not be in the exemption list. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

NamedNode.getName() returns @nullable String, so use Objects.toString to handle null names (e.g. anonymous OperationDefinition). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

dondonz · 2026-03-21T07:36:34Z

        return ImmutableKit.filterAndMap(copy,
                node1 -> node1 instanceof NamedNode,
-                node1 -> ((NamedNode) node1).getName());
+                node1 -> Objects.toString(((NamedNode) node1).getName(), ""));


This is an awkward consequence of OperationDefinition technically allowing a nullable name.

These classes are annotated with @NullMarked on this branch but were still in the exemption list after the merge from master. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

visitInlineFragment coverage dropped due to NamedNode.getName() returning @nullable — the null-check branch is not exercised in tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

andimarek

Looks good except the test-baseline change ... this should not be touched on the PR

andimarek · 2026-04-19T21:54:02Z

-    public InlineFragment(TypeName typeCondition) {
-        this(typeCondition, emptyList(), null, null, emptyList(), IgnoredChars.EMPTY, emptyMap());
+    public InlineFragment(@Nullable TypeName typeCondition) {
+        this(typeCondition, emptyList(), SelectionSet.newSelectionSet().build(), null, emptyList(), IgnoredChars.EMPTY, emptyMap());


fair ... I think we should not allow null selection set here.

andimarek · 2026-04-19T21:58:10Z

        "line": {
          "covered": 52,
-          "missed": 0
+          "missed": 1


the PR should never touch the test baseline ... it is getting changed when it runs on master.

Copilot AI and others added 4 commits January 24, 2026 20:32

Initial plan

c60fdf6

Add JSpecify annotations to 10 classes in graphql.language package

c02fa4e

Co-authored-by: dondonz <13839920+dondonz@users.noreply.github.com>

Update JSpecify annotation prompt with effectiveness improvements

3db2dde

Co-authored-by: dondonz <13839920+dondonz@users.noreply.github.com>

Initial plan

0dad526

Copilot AI assigned Copilot and dondonz Jan 25, 2026

Copilot started work on behalf of dondonz January 25, 2026 06:36 View session

Copilot AI changed the title ~~[WIP] Add JSpecify annotations to GraphQL language classes~~ Add JSpecify annotations to 10 language package classes Jan 25, 2026

Copilot AI requested a review from dondonz January 25, 2026 06:49

Copilot finished work on behalf of dondonz January 25, 2026 06:49

Copilot AI mentioned this pull request Jan 28, 2026

Review all open JSpecify PRs #4231

Closed

dondonz changed the base branch from copilot/add-jspecify-annotations-to-classes to master February 8, 2026 07:16

Merge branch 'master' into copilot/add-jspecify-annotations-another-one

0fb0195

dondonz reviewed Feb 21, 2026

View reviewed changes

dondonz added breaking change requires a new major version to be relased labels Feb 21, 2026

dondonz marked this pull request as ready for review February 21, 2026 05:57

Merge branch 'master' into copilot/add-jspecify-annotations-another-one

bef253e

Resolve JSpecifyAnnotationsCheck conflict by taking master's exemption list updates. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Remove already-annotated classes from JSpecify exemption list

6c6937c

NodeVisitor, NodeVisitorStub, SourceLocation, and Type are already annotated with @NullMarked so they should not be in the exemption list. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

dondonz added this to the 26.x is a breaking change release (other fixes as well) milestone Mar 21, 2026

Fix NullAway error in NodeParentTree.mkPath

1c06030

NamedNode.getName() returns @nullable String, so use Objects.toString to handle null names (e.g. anonymous OperationDefinition). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

dondonz reviewed Mar 21, 2026

View reviewed changes

dondonz and others added 2 commits March 21, 2026 18:43

Remove 15 already-annotated classes from JSpecify exemption list

e54472d

These classes are annotated with @NullMarked on this branch but were still in the exemption list after the merge from master. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Update test baseline for Anonymizer$4 coverage

c2f45d5

visitInlineFragment coverage dropped due to NamedNode.getName() returning @nullable — the null-check branch is not exercised in tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

andimarek requested changes Apr 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add JSpecify annotations to 10 language package classes#4219

Add JSpecify annotations to 10 language package classes#4219
Copilot wants to merge 11 commits intomasterfrom
copilot/add-jspecify-annotations-another-one

Copilot AI commented Jan 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 20, 2026 •

edited

Loading

Uh oh!

dondonz Feb 21, 2026

Uh oh!

andimarek Apr 19, 2026

Uh oh!

dondonz commented Feb 21, 2026

Uh oh!

github-actions Bot commented Mar 21, 2026 •

edited

Loading

Uh oh!

dondonz Mar 21, 2026

Uh oh!

andimarek left a comment

Uh oh!

andimarek Apr 19, 2026

Uh oh!

andimarek Apr 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Classes Annotated

Nullability Decisions

Technical Fixes

Task

Classes to annotate

Instructions

Validation

Cleanup

Reference

Uh oh!

github-actions Bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

dondonz Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

andimarek Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

dondonz commented Feb 21, 2026

Uh oh!

github-actions Bot commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Report

Test Results

Code Coverage (Java 25)

Uh oh!

dondonz Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

andimarek left a comment

Choose a reason for hiding this comment

Uh oh!

andimarek Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

andimarek Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jan 25, 2026 •

edited

Loading

github-actions Bot commented Feb 20, 2026 •

edited

Loading

github-actions Bot commented Mar 21, 2026 •

edited

Loading