Skip to content

Return a singleton from CoercedVariables.emptyVariables and RawVariables.emptyVariables #3801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dondonz merged 1 commit into from
Jan 27, 2025
Merged

Return a singleton from CoercedVariables.emptyVariables and RawVariables.emptyVariables #3801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/graphql/execution/CoercedVariables.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
*/
@PublicApi
public class CoercedVariables {
private static final CoercedVariables EMPTY = CoercedVariables.of(ImmutableKit.emptyMap());
private final ImmutableMapWithNullValues<String, Object> coercedVariables;

public CoercedVariables(Map<String, Object> coercedVariables) {
Expand All @@ -30,7 +31,7 @@ public Object get(String key) {
}

public static CoercedVariables emptyVariables() {
return new CoercedVariables(ImmutableKit.emptyMap());
return EMPTY;
}

public static CoercedVariables of(Map<String, Object> coercedVariables) {
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/graphql/execution/RawVariables.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
*/
@PublicApi
public class RawVariables {
private static final RawVariables EMPTY = RawVariables.of(ImmutableKit.emptyMap());
private final ImmutableMapWithNullValues<String, Object> rawVariables;

public RawVariables(Map<String, Object> rawVariables) {
Expand All @@ -30,7 +31,7 @@ public Object get(String key) {
}

public static RawVariables emptyVariables() {
return RawVariables.of(ImmutableKit.emptyMap());
return EMPTY;
}

public static RawVariables of(Map<String, Object> rawVariables) {
Expand Down