Conversation
Member
Author
are the tests that break if SourceLocations are naively turned off. Most are asserting on a SourceLocation being the source of the error for test assertion reasons. Looking at the runtime code, SourceLocation is treated as a read only thing. I cant see much code that deconstructs a SourceLocation |
# Conflicts: # src/main/java/graphql/parser/ParserOptions.java
andimarek
approved these changes
Jul 14, 2021
# Conflicts: # src/test/groovy/graphql/parser/ParserTest.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default they are LEFT ON - but if some one is determined to save memory OR we decide in the future, then we can turn them off (say just for SDL)
Dependent on #2438