refactor the normalized input to contain literals and add AST Compiler#2338
Merged
Conversation
bbakerman
approved these changes
May 20, 2021
# Conflicts: # src/main/java/graphql/execution/ValuesResolver.java
# Conflicts: # src/main/java/graphql/normalized/FieldCollectorNormalizedQuery.java
bbakerman
reviewed
May 24, 2021
| */ | ||
| public static Object externalValueToInternalValue(GraphqlFieldVisibility fieldVisibility, Object externalValue, GraphQLInputType type) { | ||
| return new ValuesResolver().externalValueToInternalValue(fieldVisibility, type, externalValue, ValueMode.COERCED); | ||
| return new ValuesResolver().externalValueToInternalValue(fieldVisibility, type, externalValue); |
Member
There was a problem hiding this comment.
I think this is a bad pattern BTW - that is ValuesResolver is a stateless class - so make it method static.
No object allocation needed - even with escape analysis its a bit better
Member
Author
There was a problem hiding this comment.
Yeah .. not really happy about it myself... changed it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It refactors the normalized input to reference literals and not internal input values.
It also adds a way to convert a Normalized query to an Ast.