Now checking for @deprecated location correctness#2018
Merged
andimarek merged 4 commits intoNov 2, 2020
Merged
Conversation
Member
|
The initial Issue says that input types are not correctly checked: I can only see that input types are added here as additional check. That correct? |
…e-is-checked-for-location-correctedness # Conflicts: # src/main/java/graphql/schema/idl/SchemaGeneratorHelper.java
Member
Author
|
Yes that's correct |
andimarek
approved these changes
Oct 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1949
We already added the @deprecated and @specifiedBy magic directives into the mix - so we can use standard validation for them
We no longer need the magic checking - I think this was before we added the magic directive definitions in place.
This consolidates that code a little and moves where the constants live