Subscriptions onComplete drops message#1781
Closed
ashley-taylor wants to merge 2 commits into
Closed
Conversation
added 2 commits
February 3, 2020 15:53
When onComplete is called from the parent subscription it instantly completes the downstream subscriptions. If any messages are still being processed in a CompletionStage they where lost. This patch confirms no messages are in flight before completing downstream endpoint
Author
|
The Unit test that fails also fails on master for me. |
bbakerman
reviewed
Feb 28, 2020
|
|
||
| when: | ||
| Publisher<Integer> rxIntegers = Flowable.range(0, 10) | ||
| Executor executor = CompletableFuture.delayedExecutor(50, TimeUnit.MILLISECONDS) |
Member
There was a problem hiding this comment.
The tests are failing because CompletableFuture.delayedExecutor is a Java 9 API
Member
|
Closing this in favour of the other PR However thanks for this PR because it helped us progress the problem and helped us attack it in code terms |
Author
|
Awesome, missed your comment from last week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When onComplete is called from the parent subscription it instantly
completes the downstream subscriptions.
If any messages are still being processed in a CompletionStage they
where lost.
This patch confirms no messages are in flight before completing
downstream endpoint