Skip to content

make sure variables map and query can't be null#1596

Merged
andimarek merged 5 commits intomasterfrom
non-null-variables
Jul 13, 2019
Merged

make sure variables map and query can't be null#1596
andimarek merged 5 commits intomasterfrom
non-null-variables

Conversation

@andimarek
Copy link
Copy Markdown
Member

No description provided.

@andimarek andimarek changed the title make sure variables and query can't be null make sure variables map and query can't be null Jul 10, 2019
@andimarek andimarek requested a review from bbakerman July 10, 2019 21:14
@grrttedwards
Copy link
Copy Markdown
Contributor

grrttedwards commented Jul 11, 2019

@andimarek Just out of curiosity, since I'm the author of that issue -- is this PR supposed to actually initialize that map? Or was that done somewhere else? You mentioned the "code path was not valid", so I assume the latter.

Thanks

@andimarek
Copy link
Copy Markdown
Member Author

@grrttedwards sorry if it was not clear: we have always initiated the map with an empty map, but you were able to set it to null. The new PR makes sure it is never set to null.
With "code path not valid" I mean I was not able to reproduce the exact Exception because we changed things but I got another Exception.
Does this help?

@andimarek andimarek merged commit 8c71e18 into master Jul 13, 2019
@grrttedwards
Copy link
Copy Markdown
Contributor

@andimarek Wow, I completely missed the root cause of my issue — that I was actually setting it to null! Duh!

Thanks for the reply. Keep up the good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants