make sure variables map and query can't be null#1596
Merged
Conversation
Contributor
|
@andimarek Just out of curiosity, since I'm the author of that issue -- is this PR supposed to actually initialize that map? Or was that done somewhere else? You mentioned the "code path was not valid", so I assume the latter. Thanks |
Member
Author
|
@grrttedwards sorry if it was not clear: we have always initiated the map with an empty map, but you were able to set it to |
bbakerman
approved these changes
Jul 13, 2019
Contributor
|
@andimarek Wow, I completely missed the root cause of my issue — that I was actually setting it to null! Duh! Thanks for the reply. Keep up the good work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.