The line numbers of elements are no longer off by one#1513
Merged
bbakerman merged 1 commit intographql-java:masterfrom May 1, 2019
Merged
The line numbers of elements are no longer off by one#1513bbakerman merged 1 commit intographql-java:masterfrom
bbakerman merged 1 commit intographql-java:masterfrom
Conversation
andimarek
approved these changes
Apr 26, 2019
Member
andimarek
left a comment
There was a problem hiding this comment.
I think we should use create... instead of mk... ... my 2 cent :-)
|
|
||
| class SourceLocationHelper { | ||
|
|
||
| static SourceLocation mkSourceLocation(MultiSourceReader multiSourceReader, Token token) { |
Member
There was a problem hiding this comment.
I know we have it already at some other places, but I really prefer create... over mk.... I think it is just clearer.
| @@ -36,12 +37,8 @@ public Token recoverInline(Parser recognizer) throws RecognitionException { | |||
| } | |||
|
|
|||
| InvalidSyntaxException mkMoreTokensException(Token token) { | |||
Member
There was a problem hiding this comment.
see my other comment about mk... :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #1512
The previous multi source line reader work was a bit hasty in how it calculated line numbers.
Antler is 1s based while the multi source reader is zeroes based - so we got out by one
And then the tests got updated to reflect it - even though it was wrong in practice
This corrects that