enable unicorn/prefer-logical-operator-over-ternary rule (#2941)

dimaMachina · web-flow · commit 4a8b2e1766a3 · 2022-12-08T11:35:11.000+01:00
diff --git a/.changeset/dirty-turkeys-study.md b/.changeset/dirty-turkeys-study.md
@@ -0,0 +1,7 @@
+---
+'codemirror-graphql': patch
+'graphiql': patch
+'graphql-language-service': patch
+---
+
+enable `unicorn/prefer-logical-operator-over-ternary` rule
diff --git a/packages/codemirror-graphql/src/__tests__/lint-test.ts b/packages/codemirror-graphql/src/__tests__/lint-test.ts
@@ -19,7 +19,7 @@ import { TestSchema } from './testSchema';
 function createEditorWithLint(lintConfig?: any) {
   return CodeMirror(document.createElement('div'), {
     mode: 'graphql',
-    lint: lintConfig ? lintConfig : true,
+    lint: lintConfig || true,
   });
 }
 
diff --git a/packages/codemirror-graphql/src/variables/__tests__/lint-test.ts b/packages/codemirror-graphql/src/variables/__tests__/lint-test.ts
@@ -19,7 +19,7 @@ import '../mode';
 function createEditorWithLint(lintConfig?: any) {
   return CodeMirror(document.createElement('div'), {
     mode: 'graphql-variables',
-    lint: lintConfig ? lintConfig : true,
+    lint: lintConfig || true,
   });
 }
 
diff --git a/packages/graphiql/postcss.config.js b/packages/graphiql/postcss.config.js
@@ -2,9 +2,7 @@ module.exports = ({ file, options }) => ({
   plugins: {
     'postcss-import': { root: file.dirname },
     // contains autoprefixer, etc
-    'postcss-preset-env': options['postcss-preset-env']
-      ? options['postcss-preset-env']
-      : false,
+    'postcss-preset-env': options['postcss-preset-env'] || false,
     cssnano: process.env.NODE_ENV === 'production' ? options.cssnano : false,
   },
 });
diff --git a/packages/graphiql/src/components/GraphiQL.tsx b/packages/graphiql/src/components/GraphiQL.tsx
@@ -303,9 +303,7 @@ export function GraphiQLInterface(props: GraphiQLInterfaceProps) {
       <ToolbarButton onClick={() => copy()} label="Copy query (Shift-Ctrl-C)">
         <CopyIcon className="graphiql-toolbar-icon" aria-hidden="true" />
       </ToolbarButton>
-      {props.toolbar?.additionalContent
-        ? props.toolbar.additionalContent
-        : null}
+      {props.toolbar?.additionalContent || null}
     </>
   );
 
diff --git a/packages/graphql-language-service/src/interface/getHoverInformation.ts b/packages/graphql-language-service/src/interface/getHoverInformation.ts
@@ -232,7 +232,7 @@ function renderDeprecation(
     return;
   }
 
-  const reason = def.deprecationReason ? def.deprecationReason : null;
+  const reason = def.deprecationReason || null;
   if (!reason) {
     return;
   }
diff --git a/packages/graphql-language-service/src/parser/CharacterStream.ts b/packages/graphql-language-service/src/parser/CharacterStream.ts
@@ -53,9 +53,7 @@ export default class CharacterStream implements CharacterStreamInterface {
   public sol = (): boolean => this._pos === 0;
 
   public peek = (): string | null => {
-    return this._sourceText.charAt(this._pos)
-      ? this._sourceText.charAt(this._pos)
-      : null;
+    return this._sourceText.charAt(this._pos) || null;
   };
 
   public next = (): string => {

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ import { TestSchema } from './testSchema';`
`19`	`19`	`function createEditorWithLint(lintConfig?: any) {`
`20`	`20`	`return CodeMirror(document.createElement('div'), {`
`21`	`21`	`mode: 'graphql',`
`22`		`- lint: lintConfig ? lintConfig : true,`
	`22`	`+ lint: lintConfig \|\| true,`
`23`	`23`	`});`
`24`	`24`	`}`
`25`	`25`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ import '../mode';`
`19`	`19`	`function createEditorWithLint(lintConfig?: any) {`
`20`	`20`	`return CodeMirror(document.createElement('div'), {`
`21`	`21`	`mode: 'graphql-variables',`
`22`		`- lint: lintConfig ? lintConfig : true,`
	`22`	`+ lint: lintConfig \|\| true,`
`23`	`23`	`});`
`24`	`24`	`}`
`25`	`25`
Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,7 @@ function renderDeprecation(`
`232`	`232`	`return;`
`233`	`233`	`}`
`234`	`234`
`235`		`- const reason = def.deprecationReason ? def.deprecationReason : null;`
	`235`	`+ const reason = def.deprecationReason \|\| null;`
`236`	`236`	`if (!reason) {`
`237`	`237`	`return;`
`238`	`238`	`}`