enable unicorn/throw-new-error rule (#2938)

dimaMachina · web-flow · commit 6a9d913f0d1b · 2022-12-08T11:34:54.000+01:00
diff --git a/.changeset/sweet-olives-flow.md b/.changeset/sweet-olives-flow.md
@@ -0,0 +1,9 @@
+---
+'graphiql': patch
+'@graphiql/toolkit': patch
+'graphql-language-service': patch
+'graphql-language-service-cli': patch
+'monaco-graphql': patch
+---
+
+enable `unicorn/throw-new-error` rule
diff --git a/examples/monaco-graphql-react-vite/src/App.tsx b/examples/monaco-graphql-react-vite/src/App.tsx
@@ -160,7 +160,7 @@ export default function App() {
       getSchema()
         .then(data => {
           if (!('data' in data)) {
-            throw Error(
+            throw new Error(
               'this demo does not support subscriptions or http multipart yet',
             );
           }
diff --git a/packages/graphiql-toolkit/src/create-fetcher/createFetcher.ts b/packages/graphiql-toolkit/src/create-fetcher/createFetcher.ts
@@ -30,7 +30,7 @@ export function createGraphiQLFetcher(options: CreateFetcherOptions): Fetcher {
     httpFetch = options.fetch;
   }
   if (!httpFetch) {
-    throw Error('No valid fetcher implementation available');
+    throw new Error('No valid fetcher implementation available');
   }
   // simpler fetcher for schema requests
   const simpleFetcher = createSimpleFetcher(options, httpFetch);
@@ -56,7 +56,7 @@ export function createGraphiQLFetcher(options: CreateFetcherOptions): Fetcher {
       const wsFetcher = getWsFetcher(options, fetcherOpts);
 
       if (!wsFetcher) {
-        throw Error(
+        throw new Error(
           `Your GraphiQL createFetcher is not properly configured for websocket subscriptions yet. ${
             options.subscriptionUrl
               ? `Provided URL ${options.subscriptionUrl} failed`
diff --git a/packages/graphiql-toolkit/src/create-fetcher/lib.ts b/packages/graphiql-toolkit/src/create-fetcher/lib.ts
@@ -89,7 +89,7 @@ export const createWebsocketsFetcherFromUrl = (
   } catch (err) {
     if (errorHasCode(err)) {
       if (err.code === 'MODULE_NOT_FOUND') {
-        throw Error(
+        throw new Error(
           "You need to install the 'graphql-ws' package to use websockets when passing a 'subscriptionUrl'",
         );
       }
diff --git a/packages/graphiql/src/components/GraphiQL.tsx b/packages/graphiql/src/components/GraphiQL.tsx
@@ -58,7 +58,7 @@ import {
 const majorVersion = parseInt(React.version.slice(0, 2), 10);
 
 if (majorVersion < 16) {
-  throw Error(
+  throw new Error(
     [
       'GraphiQL 0.18.0 and after is not compatible with React 15 or below.',
       'If you are using a CDN source (jsdelivr, unpkg, etc), follow this example:',
diff --git a/packages/graphql-language-service-cli/src/client.ts b/packages/graphql-language-service-cli/src/client.ts
@@ -152,7 +152,7 @@ function _getOutline(queryText: string): EXIT_CODE {
     if (outline) {
       process.stdout.write(JSON.stringify(outline, null, 2));
     } else {
-      throw Error('Error parsing or no outline tree found');
+      throw new Error('Error parsing or no outline tree found');
     }
   } catch (error) {
     process.stderr.write(formatUnknownError(error) + '\n');
diff --git a/packages/graphql-language-service/src/interface/getDefinition.ts b/packages/graphql-language-service/src/interface/getDefinition.ts
@@ -59,7 +59,7 @@ export async function getDefinitionQueryResultForNamedType(
   );
 
   if (defNodes.length === 0) {
-    throw Error(`Definition not found for GraphQL type ${name}`);
+    throw new Error(`Definition not found for GraphQL type ${name}`);
   }
   const definitions: Array<Definition> = defNodes.map(
     ({ filePath, content, definition }) =>
@@ -82,7 +82,7 @@ export async function getDefinitionQueryResultForField(
   );
 
   if (defNodes.length === 0) {
-    throw Error(`Definition not found for GraphQL type ${typeName}`);
+    throw new Error(`Definition not found for GraphQL type ${typeName}`);
   }
 
   const definitions: Array<Definition> = [];
@@ -119,7 +119,7 @@ export async function getDefinitionQueryResultForFragmentSpread(
   );
 
   if (defNodes.length === 0) {
-    throw Error(`Definition not found for GraphQL fragment ${name}`);
+    throw new Error(`Definition not found for GraphQL fragment ${name}`);
   }
   const definitions: Array<Definition> = defNodes.map(
     ({ filePath, content, definition }) =>
@@ -150,7 +150,7 @@ function getDefinitionForFragmentDefinition(
 ): Definition {
   const name = definition.name;
   if (!name) {
-    throw Error('Expected ASTNode to have a Name.');
+    throw new Error('Expected ASTNode to have a Name.');
   }
 
   return {
diff --git a/packages/monaco-graphql/src/LanguageService.ts b/packages/monaco-graphql/src/LanguageService.ts
@@ -140,7 +140,7 @@ export class LanguageService {
           },
         });
       } catch (err) {
-        throw Error(
+        throw new Error(
           `Failed parsing externalFragmentDefinitions string:\n${this._externalFragmentDefinitionsString}`,
         );
       }
diff --git a/packages/monaco-graphql/src/graphqlMode.ts b/packages/monaco-graphql/src/graphqlMode.ts
@@ -26,7 +26,7 @@ export function setupMode(defaults: MonacoGraphQLAPI): IDisposable {
     try {
       return client!.getLanguageServiceWorker(...uris);
     } catch (err) {
-      throw Error('Error fetching graphql language service worker');
+      throw new Error('Error fetching graphql language service worker');
     }
   };
 
diff --git a/packages/monaco-graphql/src/languageFeatures.ts b/packages/monaco-graphql/src/languageFeatures.ts
@@ -132,7 +132,7 @@ export class DiagnosticsAdapter {
 
     if (variablesUris) {
       if (variablesUris.length < 1) {
-        throw Error('no variables URI strings provided to validate');
+        throw new Error('no variables URI strings provided to validate');
       }
       const jsonSchema = await worker.doGetVariablesJSONSchema(
         resource.toString(),
diff --git a/packages/monaco-graphql/src/schemaLoader.ts b/packages/monaco-graphql/src/schemaLoader.ts
@@ -28,5 +28,5 @@ export const defaultSchemaLoader: SchemaLoader = (schemaConfig, parser) => {
   if (documentAST) {
     return buildASTSchema(documentAST, buildSchemaOptions);
   }
-  throw Error('no schema supplied');
+  throw new Error('no schema supplied');
 };
diff --git a/packages/monaco-graphql/src/utils.ts b/packages/monaco-graphql/src/utils.ts
@@ -163,5 +163,5 @@ export const getStringSchema = (schemaConfig: SchemaConfig) => {
       documentString: printSchema(schema),
     };
   }
-  throw Error('no schema supplied');
+  throw new Error('no schema supplied');
 };
diff --git a/scripts/renameFileExtensions.js b/scripts/renameFileExtensions.js
@@ -51,5 +51,5 @@ if (tempPath) {
     rimraf.sync(tempRenamePath);
   });
 } else {
-  throw Error(`Could not generate temporary path\n${tempRenamePath}`);
+  throw new Error(`Could not generate temporary path\n${tempRenamePath}`);
 }
diff --git a/scripts/set-resolution.js b/scripts/set-resolution.js
@@ -4,12 +4,12 @@ const path = require('path');
 async function setResolution() {
   const [, , tag] = process.argv;
   if (!tag) {
-    throw Error('no tag provided');
+    throw new Error('no tag provided');
   }
 
   const [package, version] = tag.split('@');
   if (!package || !version) {
-    throw Error(`Invalid tag ${tag}`);
+    throw new Error(`Invalid tag ${tag}`);
   }
   const pkgPath = path.resolve(path.join(process.cwd(), 'package.json'));
   const pkg = JSON.parse((await readFile(pkgPath, 'utf-8')).toString());

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ export default function App() {`
`160`	`160`	`getSchema()`
`161`	`161`	`.then(data => {`
`162`	`162`	`if (!('data' in data)) {`
`163`		`- throw Error(`
	`163`	`+ throw new Error(`
`164`	`164`	`'this demo does not support subscriptions or http multipart yet',`
`165`	`165`	`);`
`166`	`166`	`}`
Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ export const createWebsocketsFetcherFromUrl = (`
`89`	`89`	`} catch (err) {`
`90`	`90`	`if (errorHasCode(err)) {`
`91`	`91`	`if (err.code === 'MODULE_NOT_FOUND') {`
`92`		`- throw Error(`
	`92`	`+ throw new Error(`
`93`	`93`	`"You need to install the 'graphql-ws' package to use websockets when passing a 'subscriptionUrl'",`
`94`	`94`	`);`
`95`	`95`	`}`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ import {`
`58`	`58`	`const majorVersion = parseInt(React.version.slice(0, 2), 10);`
`59`	`59`
`60`	`60`	`if (majorVersion < 16) {`
`61`		`- throw Error(`
	`61`	`+ throw new Error(`
`62`	`62`	`[`
`63`	`63`	`'GraphiQL 0.18.0 and after is not compatible with React 15 or below.',`
`64`	`64`	`'If you are using a CDN source (jsdelivr, unpkg, etc), follow this example:',`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ function _getOutline(queryText: string): EXIT_CODE {`
`152`	`152`	`if (outline) {`
`153`	`153`	`process.stdout.write(JSON.stringify(outline, null, 2));`
`154`	`154`	`} else {`
`155`		`- throw Error('Error parsing or no outline tree found');`
	`155`	`+ throw new Error('Error parsing or no outline tree found');`
`156`	`156`	`}`
`157`	`157`	`} catch (error) {`
`158`	`158`	`process.stderr.write(formatUnknownError(error) + '\n');`
Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ export class LanguageService {`
`140`	`140`	`},`
`141`	`141`	`});`
`142`	`142`	`} catch (err) {`
`143`		`- throw Error(`
	`143`	`+ throw new Error(`
`144`	`144`	`Failed parsing externalFragmentDefinitions string:\n${this._externalFragmentDefinitionsString}`,
`145`	`145`	`);`
`146`	`146`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ export function setupMode(defaults: MonacoGraphQLAPI): IDisposable {`
`26`	`26`	`try {`
`27`	`27`	`return client!.getLanguageServiceWorker(...uris);`
`28`	`28`	`} catch (err) {`
`29`		`- throw Error('Error fetching graphql language service worker');`
	`29`	`+ throw new Error('Error fetching graphql language service worker');`
`30`	`30`	`}`
`31`	`31`	`};`
`32`	`32`
Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ export class DiagnosticsAdapter {`
`132`	`132`
`133`	`133`	`if (variablesUris) {`
`134`	`134`	`if (variablesUris.length < 1) {`
`135`		`- throw Error('no variables URI strings provided to validate');`
	`135`	`+ throw new Error('no variables URI strings provided to validate');`
`136`	`136`	`}`
`137`	`137`	`const jsonSchema = await worker.doGetVariablesJSONSchema(`
`138`	`138`	`resource.toString(),`