Open
Conversation
…ant DA creation Previously, load() created a LandmarkStorage just to check if data existed, then discarded it and removed the DataAccess entries from the directory. PrepareLandmarks would then create a new LandmarkStorage, re-registering the same DAs. Now the LandmarkStorage created during load() is passed through to PrepareLandmarks, avoiding the ugly DA cleanup and the unnecessary double creation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… redundant DA creation Same pattern as the LM fix: CHPreparationHandler.load() now passes back CHStorage objects that failed to load, and prepare() reuses them instead of creating new ones. This removes the ugly DA cleanup from the directory after failed loads. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids the removal and uses the initially created DataAccess instances.
Also tested manually that we can still add the CH/LM later or start without previously created ones.