Fix missing instructions at forks where side road is slower#3283
Open
modhtom wants to merge 1 commit intographhopper:masterfrom
Open
Fix missing instructions at forks where side road is slower#3283modhtom wants to merge 1 commit intographhopper:masterfrom
modhtom wants to merge 1 commit intographhopper:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes missing instructions at splits (Y-forks) where the side road is significantly slower.
Added a fallback check using EdgeIterator. If the instruction is about to be suppressed due to speed, we check the geometry of the outgoing edges. If we find a valid edge with a shallow angle (< 1.3 rad), we force the instruction to be generated.
I tested this on this road and it works. The turn angle there is 1.19, which is captured by the 1.3 threshold, correctly returning a "Turn slight right".