Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #3135 where necessary "Keep Left" or "Keep Right" instructions were ignored on motorways when the road class and name remained constant.
Previously
InstructionsFromEdgeswould aggressively Ignore instructions if roadClass == prevRoadClass.I modified the suppression logic in getTurn():
The new check is applied only to MOTORWAY and TRUNK. All other road classes retain the original behavior.
For motorways/trunks, we now check the angle of the alternative path.
If the link peels off sharply (effectiveOtherDelta > 0.22), we assume it is visually obvious and return Instruction.IGNORE.
If the link angle is shallow (<= 0.22), we skip the ignore command, this allows the subsequent logic to generate the necessary "Keep Left/Right" instruction.
Verified at the reported location (A 565) and the A9 example. Both now correctly generate "Keep Right" / "Keep Left" instructions.
