feat: support of pyspark-client#863
Merged
SemyonSinchenko merged 8 commits intoJun 16, 2026
Merged
Conversation
james-willis
approved these changes
Jun 16, 2026
james-willis
self-requested a review
June 16, 2026 17:31
james-willis
requested changes
Jun 16, 2026
james-willis
left a comment
Collaborator
There was a problem hiding this comment.
mostly some typos and other small things
Co-authored-by: James Willis <james-willis@users.noreply.github.com>
james-willis
approved these changes
Jun 16, 2026
Collaborator
|
aside from the CI failing I approve. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #863 +/- ##
==========================================
- Coverage 81.63% 79.26% -2.37%
==========================================
Files 81 81
Lines 4682 4712 +30
Branches 574 554 -20
==========================================
- Hits 3822 3735 -87
- Misses 860 977 +117 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The pyspark-client CI job ran 'poetry install --with=connect', which also pulled the non-optional dev group and its full pyspark dependency. Full pyspark and pyspark-client both own the pyspark/ namespace, so version.py was clobbered and __version__ no longer reflected the thin client. Exclude the dev group so only pyspark-client is installed. Also gate the approx triangleCount algorithm on the connected server version (spark.version) instead of the client library __version__, since the approximate algorithm is a server-side capability and client/server versions can differ under Spark Connect.
james-willis
added a commit
to james-willis/graphframes
that referenced
this pull request
Jun 16, 2026
run_connect.py and stop_connect.py were added in graphframes#863 before the linting scope was extended to dev/. Apply black/isort and add a noqa for an unavoidable long config string so python-ci passes.
james-willis
added a commit
that referenced
this pull request
Jun 16, 2026
#864) * ci: add codespell spell check and extend python linting to dev scripts - Add codespell (config in .codespellrc) covering yml, python and scala via a new Spell Check workflow and a pre-commit hook; fix the typos it surfaced across sources and docs. graphx/ is excluded to stay aligned with upstream Apache Spark. - Extend black/flake8/isort to the dev/ and python/dev/ scripts in both the Python CI code-style step and pre-commit. * ci: pass explicit config to black/isort so root dev/ does not break discovery When ../dev is included, black/isort resolve their config from the common parent of all paths (the repo root, which has no pyproject.toml) and fall back to defaults. Pass --config/--settings-path explicitly. * ci: format dev connect scripts to satisfy extended linting run_connect.py and stop_connect.py were added in #863 before the linting scope was extended to dev/. Apply black/isort and add a noqa for an unavoidable long config string so python-ci passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Small adjustments to support
pyspark-clientand testing flow.Why are the changes needed?
Close #861