Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/scala-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ jobs:
~/.ivy2/cache
key: sbt-ivy-cache-spark-${{ matrix.spark-version}}-java-${{ matrix.java-version }}
- name: Check scalafmt
run: build/sbt -Dspark.version=${{ matrix.spark-version }} root/scalafmtCheckAll connect/scalafmtCheckAll
run: build/sbt -Dspark.version=${{ matrix.spark-version }} scalafmtCheckAll
- name: Check scalastyle
run: build/sbt -Dspark.version=${{ matrix.spark-version }} root/scalafixAll connect/scalafixAll
run: build/sbt -Dspark.version=${{ matrix.spark-version }} "scalafixAll --check"
- name: Build and Test
run: build/sbt -v -Dspark.version=${{ matrix.spark-version }} coverage +test coverageReport "project connect" coverage +test coverageReport
run: build/sbt -v -Dspark.version=${{ matrix.spark-version }} coverage +test coverageReport
- uses: codecov/codecov-action@v3
4 changes: 2 additions & 2 deletions .github/workflows/scala-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
matrix:
include:
- spark-version: 3.5.5
java-version: 11
java-version: 8
- spark-version: 4.0.0
java-version: 17
runs-on: ubuntu-latest
Expand All @@ -38,7 +38,7 @@ jobs:
distribution: 'zulu'

- name: Run the release of core
run: build/sbt -Dspark.version=${{ matrix.spark-version }} +ci-release "project connect" +ci-release
run: build/sbt -Dspark.version=${{ matrix.spark-version }} ci-release
env:
PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }}
PGP_SECRET: ${{ secrets.PGP_SECRET }}
Expand Down
6 changes: 3 additions & 3 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ lazy val commonSetting = Seq(
else
"-Wunused:imports"))

lazy val root = (project in file("."))
lazy val core = (project in file("core"))
.settings(
commonSetting,
name := "graphframes",
Expand All @@ -122,8 +122,8 @@ lazy val root = (project in file("."))
Compile / packageDoc / publishArtifact := true,
Compile / packageSrc / publishArtifact := true)

lazy val connect = (project in file("graphframes-connect"))
.dependsOn(root)
lazy val connect = (project in file("connect"))
.dependsOn(core)
.settings(
name := s"graphframes-connect",
moduleName := s"${name.value}-spark${sparkMajorVer}",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
package org.apache.spark.sql.graphframes

import java.util.Optional

import org.graphframes.connect.proto.GraphFramesAPI

import com.google.protobuf
import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
import org.apache.spark.sql.connect.planner.SparkConnectPlanner
import org.apache.spark.sql.connect.plugin.RelationPlugin
import org.graphframes.connect.proto.GraphFramesAPI

import com.google.protobuf
import java.util.Optional

class GraphFramesConnect extends RelationPlugin {
override def transform(
Expand Down
File renamed without changes.
5 changes: 1 addition & 4 deletions python/dev/build_jar.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,7 @@ def build(spark_versions: Sequence[str] = ["3.5.5"]):
sbt_build_command = [
sbt_executable,
f"-Dspark.version={spark_version}",
"clean",
"package",
"connect/clean",
"connect/package"
"package"
]
sbt_build = subprocess.Popen(
sbt_build_command,
Expand Down
4 changes: 2 additions & 2 deletions python/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ def get_gf_jar_locations() -> Tuple[str, str]:
this function will raise an exception!
"""
project_root = pathlib.Path(__file__).parent.parent.parent
core_dir = project_root / "target" / f"scala-{scala_version}"
connect_dir = project_root / "graphframes-connect" / "target" / f"scala-{scala_version}"
core_dir = project_root / "core" / "target" / f"scala-{scala_version}"
connect_dir = project_root / "connect" / "target" / f"scala-{scala_version}"

core_jar: Optional[str] = None
connect_jar: Optional[str] = None
Expand Down