-
Notifications
You must be signed in to change notification settings - Fork 371
Define built-in constants and add two circle constants #4473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mehmetoguzderin
wants to merge
15
commits into
gpuweb:main
Choose a base branch
from
mehmetoguzderin:oguz-202401-constants
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1984cc4
Start built-in constants section
mehmetoguzderin 364a657
Improve wording
mehmetoguzderin 4c0fb42
Fix typo
mehmetoguzderin 5b44bac
Merge branch 'main' into oguz-202401-constants
mehmetoguzderin 7dfd4bb
Add code points and double precision values for circle constants
mehmetoguzderin e5c41c4
Merge branch 'main' into oguz-202401-constants
mehmetoguzderin bdfdc64
Add example
mehmetoguzderin b41b838
Merge branch 'main' into oguz-202401-constants
mehmetoguzderin 61adc58
Merge branch 'main' into oguz-202401-constants
mehmetoguzderin 1868e17
Merge branch 'main' into oguz-202401-constants
mehmetoguzderin fa9198b
Merge branch 'main' into oguz-202401-constants
mehmetoguzderin 707d511
Update index.bs
mehmetoguzderin 29c3dbb
Merge branch 'main' into oguz-202401-constants
mehmetoguzderin 7812de9
Merge branch 'main' into oguz-202401-constants
mehmetoguzderin df4bf8f
Merge branch 'main' into oguz-202401-constants
mehmetoguzderin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the argument for not including
M_PI_2(PI/2) a good argument for omittingTAU? It's just one more character to writePI*2.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly an argument in support of such thinking, although I think the consensus was to add
TAUfor widespread recognition, but if the group decides otherwise today, I can change it. Though even when precision is not an issue, similar constant collections seem to be includingTAUthese days, strengthening the case for inclusion.