Merged
Conversation
Fixes gpuweb#1567, gpuweb#1471, gpuweb#1457, gpuweb#1139 * No recursion * No calling entry points * fragment shader must return position * aliasing restrictions * pointer restrictions
Contributor
jrprice
reviewed
Apr 27, 2021
Contributor
kvark
approved these changes
Apr 27, 2021
dneto0
requested changes
Apr 27, 2021
Contributor
dneto0
left a comment
There was a problem hiding this comment.
Looks great.
I've got two nits.
* clarify possible return types to disallow handles * clarify aliasing
Contributor
WGSL meeting minutes 2021-04-27
|
This was referenced Apr 29, 2021
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…ar_value (gpuweb#1674) This PR updates render_pass_descriptor:depth_stencil_attachment_depth_clear_value to check if out of range of depthClearValue is only invalid when depthLoadOp is `clear'. If depthLoadOp is not `clear`, depthClearValue should be valid even though the value is out of range. Issue: gpuweb#1618
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1567, #1471, #1457, #1139
The allowance handle pointer parameters is somewhat debatable, but I've included it since we don't have a clear alternative at the moment.