Merged
Conversation
kainino0x
approved these changes
Apr 6, 2021
Contributor
kainino0x
left a comment
There was a problem hiding this comment.
Assuming no major edits since I copyedited. LGTM including formatting stuff.
kvark
requested changes
Apr 7, 2021
Contributor
Author
|
Addressed all comments, please take a look or merge! |
kvark
approved these changes
Apr 8, 2021
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…attachment (gpuweb#1600) This PR adds test cases that check mipsLevelCount: 0 and arrayLayerCount: 0 to the render_pass,resolve:resolve_attachment test. A validation error should be generated if resolveTargetViewMipCount or resolveTargetViewArrayLayerCount is 0. Issue: 1599
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes extensive copyediting by @kainino0x