Repository navigation
WebIDL: add WebGPURasterizationStateDescriptor - #141
Merged
Merged
Conversation
Kangz
reviewed
Dec 4, 2018
kainino0x
approved these changes
Dec 4, 2018
kainino0x
left a comment
Contributor
There was a problem hiding this comment.
I don't know anything about the depth bias options, but LGTM
Author
|
@kvark , @RafaelCintron , @litherum , can you take a look at this pr? These features are basically the same among D3D12, Metal and Vulkan. A small difference is that D3D12 uses integer depth bias constant factor, while Vulkan and Metal accept floats. I use an integer here to avoid troubles with portability, just as Dzmitry pointed out at the corresponding investigation issue. |
Contributor
|
This was discussed in the 10 Dec 2018 meeting |
Contributor
|
Approved at that meeting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the discussions at #137, I submitted this pull request to update the WebIDL.
In addition, we can add some features related to rasterization state (like depth clip/clamp and triangle fill mode) as extensions if we are clear about how to add extensions in WebGPU IDL.
PTAL when you have time, @kvark , @RafaelCintron , @litherum , @kainino0x , @Kangz . Thank you.