Rendering algorithm (vertex and primitive assembly)#1293
Merged
kvark merged 5 commits intogpuweb:mainfrom Jan 28, 2021
Merged
Conversation
Kangz
reviewed
Dec 10, 2020
Contributor
Contributor
kainino0x
reviewed
Dec 14, 2020
Contributor
|
It might be easier for iterations to make an issue / PR with just the IDL for things so that you don't need to update all the Bikeshed references. |
Contributor
Author
|
This is now rebased, doesn't contain any API changes, and can be merged. More stuff to follow, of course, but we don't have to wait for it. |
kainino0x
approved these changes
Jan 27, 2021
Co-authored-by: Kai Ninomiya <kainino1@gmail.com>
kvark
commented
Jan 27, 2021
Contributor
Author
kvark
left a comment
There was a problem hiding this comment.
Nicely detailed review, thanks @kainino0x !
All except one points are addressed.
kainino0x
approved these changes
Jan 27, 2021
toji
reviewed
Jan 28, 2021
toji
approved these changes
Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #936
Based on #1288
First stab at describing how render pipeline works.
Preview | Diff