Add minmax-sampling feature #1283
Next
Next commit
Add minmax-sampling feature
- Loading branch information
commit 867e5d50e7dbc9eac3b52c4d4c471da407f90b5d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -1375,6 +1375,7 @@ enum GPUFeatureName { | |||||
| "pipeline-statistics-query", | ||||||
| "texture-compression-bc", | ||||||
| "timestamp-query", | ||||||
| "minmax-sampling", | ||||||
| }; | ||||||
| </script> | ||||||
|
|
||||||
|
|
@@ -2349,7 +2350,9 @@ match one texel. | |||||
| <script type=idl> | ||||||
| enum GPUFilterMode { | ||||||
| "nearest", | ||||||
| "linear", | ||||||
|
Contributor
There was a problem hiding this comment. Briefly considering if we try to come up with a word other than linear, since this also describes minmax filters which aren't exactly "linear"? I'm not sure what it would be; "nearest"/"linear"(/"cubic") is well understood terminology. I think they're clearest. Vulkan has an extension to use min/max with "cubic", too, fwiw: https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#textures-texel-cubic-filtering |
||||||
| "minimim", | ||||||
|
kvark marked this conversation as resolved.
Outdated
|
||||||
| "maximum", | ||||||
| }; | ||||||
| </script> | ||||||
|
|
||||||
|
|
@@ -2361,6 +2364,16 @@ enum GPUFilterMode { | |||||
| : <dfn>"linear"</dfn> | ||||||
| :: | ||||||
| Select two texels in each dimension and return a linear interpolation between their values. | ||||||
|
|
||||||
| : <dfn>"minimum"</dfn> | ||||||
| :: | ||||||
| Select two texels in each dimension and return the minimum value between them. | ||||||
| Requires {{GPUFeatureName/"minmax-sampling"}} feature to be enabled. | ||||||
|
|
||||||
| : <dfn>"maximum"</dfn> | ||||||
| :: | ||||||
| Select two texels in each dimension and return the maximum value between them. | ||||||
| Requires {{GPUFeatureName/"minmax-sampling"}} feature to be enabled. | ||||||
| </dl> | ||||||
|
|
||||||
| {{GPUCompareFunction}} specifies the behavior of a comparison sampler. If a comparison sampler is | ||||||
|
|
@@ -2429,6 +2442,11 @@ enum GPUCompareFunction { | |||||
| - |descriptor|.{{GPUSamplerDescriptor/lodMinClamp}} is greater than or equal to 0. | ||||||
| - |descriptor|.{{GPUSamplerDescriptor/lodMaxClamp}} is greater than or equal to | ||||||
| |descriptor|.{{GPUSamplerDescriptor/lodMinClamp}}. | ||||||
| - |descriptor|.{{GPUSamplerDescriptor/magFilter}} and |descriptor.{{GPUSamplerDescriptor/mipmapFilter}} | ||||||
| are either {{GPUFilterMode/"nearest"}} or {{GPUFilterMode/"linear"}}, independently. | ||||||
| - if |descriptor|.{{GPUSamplerDescriptor/minFilter}} is {{GPUFilterMode/"minimum"}} or | ||||||
| {{GPUFilterMode/"maximum"}}, then the |device|.{{device/[[features]]}} | ||||||
| [=list/contain=] {{GPUFeatureName/"minmax-sampling"}}. | ||||||
|
kvark marked this conversation as resolved.
Outdated
|
||||||
| </div> | ||||||
|
|
||||||
| <dl dfn-type=method dfn-for=GPUDevice> | ||||||
|
|
@@ -7253,6 +7271,22 @@ The following enums are supported if and only if the {{GPUFeatureName/"timestamp | |||||
| * {{GPUQueryType/"timestamp"}} | ||||||
| </dl> | ||||||
|
|
||||||
| ## <dfn dfn-type=enum-value dfn-for=GPUFeatureName>minmax-sampling</dfn> ## {#minmax-sampling} | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
Contributor
Author
There was a problem hiding this comment. We should change this across all features, consistently (as a follow-up) |
||||||
|
|
||||||
| Allows for sampling modes that take the minimum or maximum of texture values. | ||||||
|
|
||||||
| **Feature Enums** | ||||||
|
|
||||||
| The following enums are supported if and only if the {{GPUFeatureName/"minmax-sampling"}} | ||||||
| [=feature=] is enabled: | ||||||
|
|
||||||
| <dl> | ||||||
| : {{GPUFilterMode}} | ||||||
| :: | ||||||
| * {{GPUFilterMode/"minimum"}} | ||||||
| * {{GPUFilterMode/"maximum"}} | ||||||
| </dl> | ||||||
|
|
||||||
| # Appendices # {#appendices} | ||||||
|
|
||||||
| ## Texture Format Capabilities ## {#texture-format-caps} | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is minmax sampling allowed for uint, int textures, but also for comparison samplers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The minmax feature in vulkan doesn't require support for any integer formats, so I assume we wouldn't support any. It also can't be used with comparison samplers apparently (kinda weird).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be, but getting the stats for this is hard :(
For now the spec only allows it on a few selected formats (see last commit).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that's not a lot of formats.