Repository navigation
[editorial] Move atomic-vec2u-min-max to chronological position - #10497
Merged
Merged
Conversation
Contributor
|
Previews, as seen when this build job started (2930f1a): |
kainino0x
added a commit
to gpuweb/types
that referenced
this pull request
Sep 19, 2026
gpuweb/gpuweb#10497 This has no actual effect, really this PR is just for testing the publish automation as this this should trigger publishing a new package version.
|
Hey, this would be great to land. As a minor detail, it does matter for convenience when I'm adding new features for JS <-> Wasm marshalling at https://github.com/juj/wasm_webgpu/ That way I don't need to reshuffle the feature enum values. Of course my bindings API does not guarantee a stable enum value set, but it's good to strive to keep the list unchanged, so +1 for landing this PR. |
Contributor
Author
|
@toji could you review, and then help get this PR landed since I have limited work time right now |
toji
approved these changes
Oct 16, 2026
toji
left a comment
Member
There was a problem hiding this comment.
Apologies that I missed this review earlier. LGTM!
The order doesn't matter in WebIDL, but it's useful to maintain this order so it matches the Feature Index as well as things like webgpu.h where the order does matter. Also update the "IMPORTANT" comments for clarity.
toji
force-pushed
the
feature-name-order
branch
from
October 16, 2026 16:41
e36a59d to
2930f1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order doesn't matter in WebIDL, but it's useful to maintain this order so it matches the Feature Index as well as things like webgpu.h where the order does matter.
Also update the "IMPORTANT" comments for clarity.