feat: add network segment range extension to networking v2#3614
Open
cardoe wants to merge 1 commit intogophercloud:mainfrom
Open
feat: add network segment range extension to networking v2#3614cardoe wants to merge 1 commit intogophercloud:mainfrom
cardoe wants to merge 1 commit intogophercloud:mainfrom
Conversation
Add support for Neutron's network segment range extension to the networking/v2 module.
cardoe
added a commit
to cardoe/openstack-resource-controller
that referenced
this pull request
Jan 27, 2026
Added an implementation to manage Network Segment Ranges which is a Neutron extension. This depends on gophercloud/gophercloud#3614. For now it pulls that in with a replacement in go.mod.
Contributor
Author
|
The testing failure is: Not something this code changes or touches or impacts. |
Contributor
Yep, this is a known issue with master branch due to eventlet removal. But I now realize the patch we were waiting for merged and the job should be back to green. |
mandre
reviewed
Jan 28, 2026
Contributor
mandre
left a comment
There was a problem hiding this comment.
This looks great!
Would it be possible to add acceptance tests as well, to ensure the feature works as expected against a live environment?
We already configure devstack with the neutron-network-segment-range extension, so the environment should be able to handle it. That said, we should add a guard similar to what's done here:
| } | ||
|
|
||
| // NetworkSegmentRange represents a network segment range. | ||
| type NetworkSegmentRange struct { |
Contributor
There was a problem hiding this comment.
Should we add all fields? We're currently missing:
- Description
- TenantID (not sure this one is relevant anymore)
- CreatedAt
- UpdatedAt
- RevisionNumber
- Tags
|
|
||
| // CreateOpts represents options for creating a network segment range. | ||
| type CreateOpts struct { | ||
| Name string `json:"name,omitempty"` |
Contributor
There was a problem hiding this comment.
Ideally we'd add godoc comments for all public fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Neutron's network segment range extension to the networking/v2 module.
Fixes #3613
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://docs.openstack.org/neutron/2025.2//admin/config-network-segment-ranges.html
https://github.com/openstack/neutron/blob/master/neutron/extensions/network_segment_range.py
https://docs.openstack.org/api-ref/network/v2/index.html#network-segment-ranges