Add the Security Group for Virtual IP#3497
Open
nguyenhuukhoi wants to merge 3 commits intogophercloud:mainfrom
Open
Add the Security Group for Virtual IP#3497nguyenhuukhoi wants to merge 3 commits intogophercloud:mainfrom
nguyenhuukhoi wants to merge 3 commits intogophercloud:mainfrom
Conversation
mandre
requested changes
Aug 18, 2025
Contributor
mandre
left a comment
There was a problem hiding this comment.
This needs modification of the acceptance tests to show this feature is working as intended.
You would have to ensure the vip_sg_ids parameter is set only in newer versions of OpenStack as this is a new feature of the 2025.1 release.
| VipQosPolicyID string `json:"vip_qos_policy_id,omitempty"` | ||
|
|
||
| // The ID of the Security Group which will apply to the Virtual IP | ||
| VipSecGroupID string `json:"vip_sg_id,omitempty"` |
Contributor
There was a problem hiding this comment.
Both the linked spec and the docs say the parameter is called vip_sg_ids in plural form. A look at the code also confirms this needs to be plural.
Contributor
|
Hi, @nguyenhuukhoi. Do you have plans to keep working on this PR? It will be a pleasure review your code to get your commits merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for Custom Security Groups for VIP Ports
https://github.com/openstack/octavia/blob/00599cb91ce9b5ab80119e329845e54f6e1e0a10/specs/version15.0/custom-security-groups-for-VIP-ports.rst#L168