Use Alert Center scope constants#68
Merged
Merged
Conversation
erickoledadevrel
suggested changes
Mar 26, 2019
|
|
||
| private static final String APPLICATION_NAME = "Google Admin SDK Alert Center API Java Quickstart"; | ||
| private static final JsonFactory JSON_FACTORY = JacksonFactory.getDefaultInstance(); | ||
| /** |
There was a problem hiding this comment.
Please keep the previous SCOPES variable and comment, as it contains important information about how to handle scope changes.
| .fromStream(in) | ||
| .createDelegated(delegatedAdminEmail) | ||
| .createScoped(SCOPES); | ||
| .createScoped(AlertCenterScopes.all()); |
There was a problem hiding this comment.
We prefer that the sample uses the minimum scopes required, since it's a best practice. See the Gmail quickstart for an example:
| * Global instance of the scopes required by this quickstart. If modifying these scopes, delete | ||
| * your previously saved tokens/ folder. | ||
| * Global instance of the scopes required by this quickstart. | ||
| * If modifying these scopes, delete your previously saved tokens/folder. |
There was a problem hiding this comment.
There actually is supposed to be a space between these. The folder is named "tokens", and we are instructing that they delete the whole folder.
erickoledadevrel
approved these changes
Mar 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.