feat: Add support of Maps Static API - #344
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
+ Coverage 88.43% 89.32% +0.88%
==========================================
Files 12 13 +1
Lines 640 721 +81
==========================================
+ Hits 566 644 +78
- Misses 74 77 +3
Continue to review full report at Codecov.
|
jpoehnelt
reviewed
Feb 10, 2020
jpoehnelt
left a comment
There was a problem hiding this comment.
Thinking out load here... It seems the marker and path arguments are not very user friendly. How about making them a little more defined? Looks good otherwise.
class StaticMapMarker:
def __init__(lcoations, size="small", color="blue", label="S"):
pass
def __str__():
pass
Contributor
Author
|
Agree with you. Now it looks better. |
jpoehnelt
suggested changes
Feb 11, 2020
jpoehnelt
left a comment
There was a problem hiding this comment.
Looks much better now. See other comments.
jpoehnelt
approved these changes
Feb 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #343