Skip to content

Remove deprecated places radar - #288

Merged
amuramoto merged 1 commit into
masterfrom
fix/places_radar
Aug 19, 2019
Merged

Remove deprecated places radar#288
amuramoto merged 1 commit into
masterfrom
fix/places_radar

Conversation

@jpoehnelt

@jpoehnelt jpoehnelt commented Aug 19, 2019

Copy link
Copy Markdown

closes #284

Announcement was at http://goo.gl/BGiumE and endpoint no longer exists.

@amuramoto

amuramoto commented Aug 19, 2019

Copy link
Copy Markdown
Member

Instead of removing entirely, should it throw with a useful error saying the field is deprecated?

@jpoehnelt

jpoehnelt commented Aug 19, 2019

Copy link
Copy Markdown
Author

I think it makes more sense to remove entirely given that it has not been functional for over a year if the end of life in the blog post is correct.

Currently the failure looks like:

.../google-maps-services-python/googlemaps/client.py in _get_body(self, response)
    277     def _get_body(self, response):
    278         if response.status_code != 200:
--> 279             raise googlemaps.exceptions.HTTPError(response.status_code)
    280 
    281         body = response.json()

HTTPError: HTTP Error: 404

Will now look like:

AttributeError: module 'googlemaps' has no attribute 'places_radar'

amuramoto
amuramoto approved these changes Aug 19, 2019
View reviewed changes

@amuramoto amuramoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amuramoto
amuramoto merged commit 5d8d006 into master Aug 19, 2019
@amuramoto
amuramoto deleted the fix/places_radar branch August 19, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenmcd stephenmcd Awaiting requested review from stephenmcd
1 more reviewer
@amuramoto amuramoto amuramoto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Did you notice that places_radar(*args, **kwargs) no longer works?

2 participants

@jpoehnelt @amuramoto