Skip to content

Include tests in sdist pypi tarball - #273

Merged
jpoehnelt merged 1 commit into
googlemaps:masterfrom
scarabeusiv:patch-1
Aug 22, 2019
Merged

Include tests in sdist pypi tarball#273
jpoehnelt merged 1 commit into
googlemaps:masterfrom
scarabeusiv:patch-1

Conversation

@scarabeusiv

Copy link
Copy Markdown
Contributor

This allows distributors to test basical sanity of their stack with googlemaps package.

This allows distributors to test basical sanity of their stack with googlemaps package.
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@scarabeusiv

Copy link
Copy Markdown
Contributor Author

I've signed the CLA

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jpoehnelt

jpoehnelt commented Aug 16, 2019

Copy link
Copy Markdown

Thanks for the contribution, I'll be going through all outstanding pull requests and issues in the next few weeks.

@jpoehnelt
jpoehnelt self-requested a review August 16, 2019 19:42

@jpoehnelt jpoehnelt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will obviously have dependency issues if trying to import from the subpackage. Might in the future consider moving test folder to toplevel and out of the package.

@jpoehnelt

Copy link
Copy Markdown

@googlebot rescan

@jpoehnelt
jpoehnelt merged commit e063ee0 into googlemaps:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants