Skip to content

Do not override headers passed in request_kwargs - #252

Merged
stephenmcd merged 2 commits into
googlemaps:masterfrom
Tecktron:save-request-headers
Sep 11, 2018
Merged

Do not override headers passed in request_kwargs#252
stephenmcd merged 2 commits into
googlemaps:masterfrom
Tecktron:save-request-headers

Conversation

@Tecktron

@Tecktron Tecktron commented Sep 10, 2018

Copy link
Copy Markdown
Contributor

If headers are passed in as part of the request_kwargs on Client creation, then make sure they are not overridden as part of the dictionary update.

If headers are passed in as part of the request_kwargs, then make sure they are not overridden as part of the load. This is required if you are limiting your API by using referer.
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@Tecktron

Copy link
Copy Markdown
Contributor Author

I signed it

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@stephenmcd

Copy link
Copy Markdown
Contributor

Makes sense, thanks a lot.

@stephenmcd
stephenmcd merged commit cda8166 into googlemaps:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants