Skip to content

Add more parameters for new billing on autocomplete and Place details - #241

Closed
SBillion wants to merge 7 commits into
googlemaps:masterfrom
SBillion:develop
Closed

Add more parameters for new billing on autocomplete and Place details#241
SBillion wants to merge 7 commits into
googlemaps:masterfrom
SBillion:develop

Conversation

@SBillion

Copy link
Copy Markdown
Contributor
  • Add possibility to set a session_token on autocomplete queries to use session for billing
  • Add fields list parameter on place details to specify which field should return the service
  • Add categories list parameter on place details to specify a set of fields. Values are basic, contact, atmoshpere

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@SBillion

Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@stephenmcd

Copy link
Copy Markdown
Contributor

This is already awaiting in #234.

Thanks all the same.

@stephenmcd stephenmcd closed this Jun 18, 2018
@SBillion

Copy link
Copy Markdown
Contributor Author

@stephenmcd Didn't see yours before but that's not exactly the same work.

  • I let the choice to not use session_token with autocomplete.
  • It's possible to use categories to set a list of fields without having to set them one by one.
  • I used black to format the project.
  • I added pipenv files to the project
  • I don't raise exception if the developer use non existent fields. I think Exception should not be raise to do what the documentation does already. But that's my point of view
  • There are no conflicts

I think our branchs could be merged as they have complementary features.

If you don't want to use my pull request, please fix and update #234

Regards,
Seb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants