Skip to content

Allow a requests.Session object to be passed into Client #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephenmcd merged 4 commits into from
Feb 13, 2017
Merged

Allow a requests.Session object to be passed into Client #164

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7f52da
Allow a requests.Session object to be passed into Client
Feb 10, 2017
573cc88
fixup! Allow a requests.Session object to be passed into Client
Feb 10, 2017
c778419
fixup! Allow a requests.Session object to be passed into Client
Feb 10, 2017
25940c4
fixup! Allow a requests.Session object to be passed into Client
Feb 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion googlemaps/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ def __init__(self, key=None, client_id=None, client_secret=None,
"alphanumeric string. The period (.), underscore (_)"
"and hyphen (-) characters are allowed.")

self.session = requests.Session()
self.key = key

if timeout and (connect_timeout or read_timeout):
Expand Down Expand Up @@ -216,7 +217,7 @@ def _get(self, url, params, first_request_time=None, retry_counter=0,
# requests_kwargs arg overriding.
requests_kwargs = dict(self.requests_kwargs, **(requests_kwargs or {}))
try:
resp = requests.get(base_url + authed_url, **requests_kwargs)
resp = self.session.get(base_url + authed_url, **requests_kwargs)
except requests.exceptions.Timeout:
raise googlemaps.exceptions.Timeout()
except Exception as e:
Expand Down