Skip to content

deps: adding JDK 11 as the supplement to java8 container#211

Merged
suztomo merged 1 commit intogoogleapis:mainfrom
suztomo:jdk11_in_java8
May 23, 2022
Merged

deps: adding JDK 11 as the supplement to java8 container#211
suztomo merged 1 commit intogoogleapis:mainfrom
suztomo:jdk11_in_java8

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented May 23, 2022 •
edited
Loading

This change enables us to build a project in JDK 11 and run tests in JDK 8 runtime.

How I confirmed the updated Docker file:

suztomo@suztomo:~/testing-infra-docker/java/java8$ docker build .
Sending build context to Docker daemon  6.144kB
Step 1/20 : FROM openjdk:8-jdk
 ---> c43167b660ad
...
Step 20/20 : WORKDIR /workspace
 ---> Running in 949d7b16df43
Removing intermediate container 949d7b16df43
 ---> 890bb1639e37
Successfully built 890bb1639e37
suztomo@suztomo:~/testing-infra-docker/java/java8$ docker run --rm -it --entrypoint bash 890bb1639e37
root@d2439762fd1a:/workspace# printenv
PYENV_SHELL=bash
HOSTNAME=d2439762fd1a
JAVA_HOME=/usr/local/openjdk-8
JAVA8_HOME=/usr/local/openjdk-8
PWD=/workspace
HOME=/root
LANG=C.UTF-8
JAVA11_HOME=/usr/lib/jvm/java-11-openjdk-amd64
TERM=xterm
SHLVL=1
PATH=/root/.pyenv/shims:/root/.pyenv/bin:/usr/local/openjdk-8/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/lib/maven/bin:/usr/local/lib/gradle/gradle-4.9/bin:/usr/local/gcloud/google-cloud-sdk/bin
JAVA_VERSION=8u332
_=/usr/bin/printenv
root@d2439762fd1a:/workspace# ${JAVA8_HOME}/bin/javac -version
javac 1.8.0_332
root@d2439762fd1a:/workspace# ${JAVA11_HOME}/bin/javac -version
javac 11.0.15
root@d2439762fd1a:/workspace# ^C
  • The image continue to use Java 8 as default JDK (See JAVA_HOME=/usr/local/openjdk-8 in the output above)
  • The generated image provides environment variables JAVA8_HOME and JAVA11_HOME for build.sh.

@suztomo suztomo requested review from a team and mpeddada1 May 23, 2022 15:14
mpeddada1
mpeddada1 approved these changes May 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mpeddada1 mpeddada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates to the build.sh files needed?

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented May 23, 2022

The required change for java-spanner is in googleapis/java-spanner#1870.

When we need to apply it to other repositories (that would touch graal-sdk), we can fix it in the template (link). Not now.

@mpeddada1
Copy link
Copy Markdown
Contributor

mpeddada1 commented May 23, 2022

Sounds great, thanks!

@suztomo suztomo merged commit 345d284 into googleapis:main May 23, 2022
@suztomo suztomo deleted the jdk11_in_java8 branch May 23, 2022 17:59
@suztomo suztomo mentioned this pull request May 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mpeddada1 mpeddada1 mpeddada1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suztomo @mpeddada1