This repository was archived by the owner on May 14, 2026. It is now read-only.
[ggj] feat: support box/primitive type equality for ternary expression - #143
Merged
Conversation
xiaozhenliu-gg5
commented
Aug 12, 2020
miraleung
suggested changes
Aug 13, 2020
miraleung
left a comment
Contributor
There was a problem hiding this comment.
Please remove the CastExpr changes from this PR, and I'll take a second pass then.
xiaozhenliu-gg5
commented
Aug 13, 2020
miraleung
suggested changes
Aug 17, 2020
miraleung
suggested changes
Aug 17, 2020
| assertEquals(ternaryExpr.thenExpr().type(), ternaryExpr.elseExpr().type()); | ||
| assertEquals(ternaryExpr.type(), TypeNode.INT_OBJECT); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Could you please confirm that we've covered all the edge cases in these tests?
Contributor
Author
There was a problem hiding this comment.
sure, added two valid unit tests that ensure: the ternary expression has the correct type with primitive/boxed type expressions in different order.
Also an invalid test to confirm the thenExpr/elseExpr should be primitive/boxed type equal.
miraleung
approved these changes
Aug 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[3/6] support boxed/primitive type equality in ternayexpression.
More details can be found in notes: go/javanaut-boxed-primitive-type-equality