Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

docs: remove an unnecessary hyphen#69

Merged
tmatsuo merged 1 commit into
googleapis:masterfrom
tmatsuo:fix-docfx
Jul 28, 2020
Merged

docs: remove an unnecessary hyphen#69
tmatsuo merged 1 commit into
googleapis:masterfrom
tmatsuo:fix-docfx

Conversation

@tmatsuo
Copy link
Copy Markdown
Contributor

@tmatsuo tmatsuo commented Jul 27, 2020

I think we should not have hyphen there.

@tmatsuo tmatsuo requested a review from busunkim96 July 27, 2020 23:41
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 27, 2020
@tmatsuo
Copy link
Copy Markdown
Contributor Author

tmatsuo commented Jul 28, 2020

With the hyphen, the intermediate filenames are something like docfx--python-texttospeech-2.1.0.tar.gz. The whole pipeline still works, but I want clean up before going to production.

@tmatsuo tmatsuo merged commit 55ff787 into googleapis:master Jul 28, 2020
@tmatsuo tmatsuo deleted the fix-docfx branch July 28, 2020 00:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmatsuo @busunkim96