Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

chore: migrate docs job to Trampoline V2#65

Merged
tmatsuo merged 7 commits into
googleapis:masterfrom
tmatsuo:docs-trampoline-v2
Jul 27, 2020
Merged

chore: migrate docs job to Trampoline V2#65
tmatsuo merged 7 commits into
googleapis:masterfrom
tmatsuo:docs-trampoline-v2

Conversation

@tmatsuo
Copy link
Copy Markdown
Contributor

@tmatsuo tmatsuo commented Jul 25, 2020

This allows us to run the whole job locally.

Example:

$ TRAMPOLINE_IMAGE=gcr.io/tmatsuo-test/python-lib-docs \
  TRAMPOLINE_DOCKERFILE=.kokoro/docker/docs/Dockerfile \
  TRAMPOLINE_BUILD_FILE=.kokoro/publish-docs.sh \
  STAGING_BUCKET=tmatsuo-test-bucket \
  .kokoro/trampoline_v2.sh

You need to copy the service account with the permission on the bucket
to /dev/shm/73713_docuploader_service_account for the above command to
work.

fixes #64

CC @tbpg

This allows us to run the whole job locally.

Example:

```bash
$ TRAMPOLINE_IMAGE=gcr.io/tmatsuo-test/python-lib-docs \
  TRAMPOLINE_DOCKERFILE=.kokoro/docker/docs/Dockerfile \
  TRAMPOLINE_BUILD_FILE=.kokoro/publish-docs.sh \
  STAGING_BUCKET=tmatsuo-test-bucket \
  .kokoro/trampoline_v2.sh
```

You need to copy the service account with the permission on the bucket
to `/dev/shm/73713_docuploader_service_account` for the above command to
work.
@tmatsuo tmatsuo requested a review from busunkim96 July 25, 2020 00:38
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2020
@tmatsuo
Copy link
Copy Markdown
Contributor Author

tmatsuo commented Jul 25, 2020

I run the docs Kokoro job against my branch with STAGING_BUCKET=tmatsuo-test-bucket and it worked.
Build log

Comment thread noxfile.py Outdated
Copy link
Copy Markdown

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tmatsuo
Copy link
Copy Markdown
Contributor Author

tmatsuo commented Jul 27, 2020

I think it's cleaner to add the environment variable in the Kokoro configs. I'll revisit it.

@tmatsuo
Copy link
Copy Markdown
Contributor Author

tmatsuo commented Jul 27, 2020

I run the docs Kokoro job against my branch with STAGING_BUCKET=tmatsuo-test-bucket again and it worked.

Build log

@tmatsuo
Copy link
Copy Markdown
Contributor Author

tmatsuo commented Jul 27, 2020

I manually checked the HTML content created by the following command:

$ TRAMPOLINE_IMAGE=gcr.io/tmatsuo-test/python-lib-docs \
  TRAMPOLINE_DOCKERFILE=.kokoro/docker/docs/Dockerfile \
  TRAMPOLINE_BUILD_FILE=.kokoro/publish-docs.sh \
  STAGING_BUCKET=tmatsuo-test-bucket \
  .kokoro/trampoline_v2.sh

and they look ok, merging.

@tmatsuo tmatsuo merged commit 928acaa into googleapis:master Jul 27, 2020
@tmatsuo tmatsuo deleted the docs-trampoline-v2 branch July 27, 2020 21:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migrate docs Kokoro job to Trampoline V2

3 participants