This repository was archived by the owner on Nov 29, 2023. It is now read-only.
chore: migrate docs job to Trampoline V2#65
Merged
Conversation
This allows us to run the whole job locally. Example: ```bash $ TRAMPOLINE_IMAGE=gcr.io/tmatsuo-test/python-lib-docs \ TRAMPOLINE_DOCKERFILE=.kokoro/docker/docs/Dockerfile \ TRAMPOLINE_BUILD_FILE=.kokoro/publish-docs.sh \ STAGING_BUCKET=tmatsuo-test-bucket \ .kokoro/trampoline_v2.sh ``` You need to copy the service account with the permission on the bucket to `/dev/shm/73713_docuploader_service_account` for the above command to work.
Contributor
Author
|
I run the |
busunkim96
reviewed
Jul 25, 2020
busunkim96
approved these changes
Jul 25, 2020
Contributor
Author
|
I think it's cleaner to add the environment variable in the Kokoro configs. I'll revisit it. |
Contributor
Author
|
I run the docs Kokoro job against my branch with STAGING_BUCKET=tmatsuo-test-bucket again and it worked. |
Contributor
Author
|
I manually checked the HTML content created by the following command: $ TRAMPOLINE_IMAGE=gcr.io/tmatsuo-test/python-lib-docs \
TRAMPOLINE_DOCKERFILE=.kokoro/docker/docs/Dockerfile \
TRAMPOLINE_BUILD_FILE=.kokoro/publish-docs.sh \
STAGING_BUCKET=tmatsuo-test-bucket \
.kokoro/trampoline_v2.shand they look ok, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to run the whole job locally.
Example:
You need to copy the service account with the permission on the bucket
to
/dev/shm/73713_docuploader_service_accountfor the above command towork.
fixes #64
CC @tbpg