Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: fix for database name in batch create request #883

Merged
asthamohta merged 4 commits into from
Jan 17, 2023
Merged

fix: fix for database name in batch create request #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8bb4394
tests
asthamohta Jan 17, 2023
b9c8daa
Merge branch 'main' into main
asthamohta Jan 17, 2023
a75fb63
changes
asthamohta Jan 17, 2023
002ef72
Merge branch 'main' of github.com:asthamohta/python-spanner
asthamohta Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/spanner_v1/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ def bind(self, database):
metadata = _metadata_with_prefix(database.name)
self._database_role = self._database_role or self._database.database_role
request = BatchCreateSessionsRequest(
database=database.database_id,
database=database.name,
session_count=self.size - self._sessions.qsize(),
session_template=Session(creator_role=self.database_role),
)
Expand Down Expand Up @@ -406,7 +406,7 @@ def bind(self, database):
self._database_role = self._database_role or self._database.database_role

request = BatchCreateSessionsRequest(
database=database.database_id,
database=database.name,
session_count=self.size - created_session_count,
session_template=Session(creator_role=self.database_role),
)
Expand Down
4 changes: 2 additions & 2 deletions tests/system/test_database_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def test_database_binding_of_fixed_size_pool(
default_timeout=500,
database_role="parent",
)
database = shared_instance.database(temp_db.name, pool=pool)
database = shared_instance.database(temp_db_id, pool=pool)
assert database._pool.database_role == "parent"


Expand Down Expand Up @@ -125,7 +125,7 @@ def test_database_binding_of_pinging_pool(
ping_interval=100,
database_role="parent",
)
database = shared_instance.database(temp_db.name, pool=pool)
database = shared_instance.database(temp_db_id, pool=pool)
assert database._pool.database_role == "parent"


Expand Down