Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: Inline Begin transction for RW transactions#840

Merged
asthamohta merged 26 commits into
googleapis:mainfrom
surbhigarg92:inline_begintransaction
Dec 14, 2022
Merged

feat: Inline Begin transction for RW transactions#840
asthamohta merged 26 commits into
googleapis:mainfrom
surbhigarg92:inline_begintransaction

Conversation

@surbhigarg92
Copy link
Copy Markdown
Contributor

No description provided.

@surbhigarg92 surbhigarg92 requested review from a team October 10, 2022 04:54
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels Oct 10, 2022
@surbhigarg92 surbhigarg92 marked this pull request as draft October 10, 2022 04:54
@surbhigarg92 surbhigarg92 force-pushed the inline_begintransaction branch from fc55e91 to d06c593 Compare October 10, 2022 18:36
@surbhigarg92 surbhigarg92 changed the title Inline Begin transction for RW transactions feat: Inline Begin transction for RW transactions Oct 10, 2022
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Nov 9, 2022
@surbhigarg92 surbhigarg92 marked this pull request as ready for review November 30, 2022 05:43
Comment thread google/cloud/spanner_v1/snapshot.py
Comment thread google/cloud/spanner_v1/snapshot.py Outdated
Comment thread google/cloud/spanner_v1/snapshot.py
Comment thread google/cloud/spanner_v1/snapshot.py Outdated
Comment thread google/cloud/spanner_v1/snapshot.py Outdated
Comment thread google/cloud/spanner_v1/pool.py
Comment thread tests/unit/test_snapshot.py
Comment thread tests/unit/test_spanner.py Outdated
Comment thread tests/unit/test_transaction.py
Comment thread tests/unit/test_transaction.py
Comment thread tests/unit/test_transaction.py
Comment thread google/cloud/spanner_v1/transaction.py Outdated
Comment thread google/cloud/spanner_v1/transaction.py
Comment thread google/cloud/spanner_v1/transaction.py
Comment thread tests/unit/test_pool.py
@surbhigarg92 surbhigarg92 force-pushed the inline_begintransaction branch 2 times, most recently from 4bfa075 to 3a002c4 Compare December 8, 2022 09:28
@surbhigarg92 surbhigarg92 requested a review from larkee December 8, 2022 15:20
Comment thread google/cloud/spanner_v1/snapshot.py
Comment thread google/cloud/spanner_v1/pool.py Outdated
Comment thread google/cloud/spanner_v1/pool.py
Comment thread google/cloud/spanner_v1/transaction.py
Comment thread tests/unit/test_session.py
Comment thread tests/unit/test_session.py Outdated
Comment thread tests/unit/test_snapshot.py Outdated
Comment thread google/cloud/spanner_v1/pool.py
surbhigarg92 and others added 4 commits December 12, 2022 14:40
Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
@surbhigarg92 surbhigarg92 requested a review from larkee December 12, 2022 11:25
Copy link
Copy Markdown
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few style nits 👍

Comment thread tests/unit/test_session.py Outdated
Comment thread tests/unit/test_snapshot.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants