This repository was archived by the owner on Mar 9, 2026. It is now read-only.
fix: use client_options.api_endpoint parameter instead of ignoring it#59
Merged
gcf-merge-on-green[bot] merged 3 commits intoMar 25, 2020
Merged
Conversation
plamut
suggested changes
Mar 25, 2020
Contributor
plamut
left a comment
There was a problem hiding this comment.
Suggested a few Improvements. Let's also open an issue for the fix so that we have it in the next release's changelog.
plamut
reviewed
Mar 25, 2020
Contributor
plamut
left a comment
There was a problem hiding this comment.
The change looks good, let's just cover the problematic edge case with an additional test.
plamut
approved these changes
Mar 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61