Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

test: cover the fix for sync pull with no messages#53

Merged
pradn merged 3 commits into
googleapis:masterfrom
plamut:iss-52
Mar 24, 2020
Merged

test: cover the fix for sync pull with no messages#53
pradn merged 3 commits into
googleapis:masterfrom
plamut:iss-52

Conversation

@plamut

@plamut plamut commented Mar 23, 2020

Copy link
Copy Markdown
Contributor

Closes #52.

This PR is a follow-up to #43, requires the latter to be merged first.

To test, simply verify that the test fails before the fix in linked PR, and passes after merging it.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added type: process A process-related concern. May include testing, release, or the like. do not merge Indicates a pull request not ready for merge, due to either quality or timing. testing labels Mar 23, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2020
Comment thread tests/system.py Outdated
@plamut plamut removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 24, 2020
@plamut plamut requested a review from pradn March 24, 2020 08:08
@pradn pradn merged commit 9abb047 into googleapis:master Mar 24, 2020
@plamut plamut deleted the iss-52 branch March 24, 2020 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement. testing type: process A process-related concern. May include testing, release, or the like.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test for 504 DeadlineExceeded for synchronous pull without published messages

3 participants