Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

docs: fix create_topic() call in README#360

Merged
pradn merged 1 commit into
googleapis:masterfrom
plamut:iss-349
Apr 1, 2021
Merged

docs: fix create_topic() call in README#360
pradn merged 1 commit into
googleapis:masterfrom
plamut:iss-349

Conversation

@plamut

@plamut plamut commented Apr 1, 2021

Copy link
Copy Markdown
Contributor

Fixes #349.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the samples Issues that are directly related to samples. label Apr 1, 2021
@plamut plamut requested review from a team and anguillanneuf April 1, 2021 09:22
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Apr 1, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2021
pradn
pradn approved these changes Apr 1, 2021
View reviewed changes

@pradn pradn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pradn pradn merged commit f5eee4b into googleapis:master Apr 1, 2021
@plamut plamut deleted the iss-349 branch April 2, 2021 07:24
@release-please release-please Bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@anguillanneuf anguillanneuf Awaiting requested review from anguillanneuf

1 more reviewer

@pradn pradn pradn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Example of using PublisherClient's create_topic method cause TypeError

2 participants

@plamut @pradn