Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

docs: add additional info on use_legacy_flow_control parameter#301

Merged
plamut merged 7 commits into
googleapis:masterfrom
plamut:iss-300
Apr 13, 2021
Merged

docs: add additional info on use_legacy_flow_control parameter#301
plamut merged 7 commits into
googleapis:masterfrom
plamut:iss-300

Conversation

@plamut

@plamut plamut commented Feb 27, 2021

Copy link
Copy Markdown
Contributor

Closes #300.

This PR adds missing info on use_legacy_flow_control parameter where applicable

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the documentation Improvements or additions to documentation label Feb 27, 2021
@plamut plamut requested a review from a team February 27, 2021 12:57
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Feb 27, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 27, 2021
@plamut plamut changed the title Iss 300 docs: add additional info on use_legacy_flow_control parameter Feb 27, 2021
anguillanneuf
anguillanneuf approved these changes Mar 16, 2021
View reviewed changes
Comment thread google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py Outdated
Comment thread google/cloud/pubsub_v1/subscriber/client.py Outdated
kamalaboulhosn
kamalaboulhosn reviewed Mar 16, 2021
View reviewed changes
Comment thread google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py Outdated
pradn
pradn reviewed Apr 1, 2021
View reviewed changes
Comment thread google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py
@plamut plamut requested a review from pradn April 2, 2021 07:37
@plamut

plamut commented Apr 12, 2021

Copy link
Copy Markdown
Contributor Author

@pradn Ping, we just need one final rubber stamp, thanks!

@plamut plamut merged commit f47523e into googleapis:master Apr 13, 2021
@plamut plamut deleted the iss-300 branch April 13, 2021 08:33
@release-please release-please Bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kamalaboulhosn kamalaboulhosn Awaiting requested review from kamalaboulhosn

@anguillanneuf anguillanneuf Awaiting requested review from anguillanneuf

@pradn pradn Awaiting requested review from pradn

1 more reviewer

@hongalex hongalex hongalex approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement. documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incomplete docstrings for the use_legacy_flow_control parameter

5 participants

@plamut @pradn @kamalaboulhosn @hongalex @anguillanneuf