Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

feat: surface SchemaServiceClient#281

Merged
anguillanneuf merged 1 commit into
googleapis:masterfrom
plamut:iss-280
Jan 29, 2021
Merged

feat: surface SchemaServiceClient#281
anguillanneuf merged 1 commit into
googleapis:masterfrom
plamut:iss-280

Conversation

@plamut
Copy link
Copy Markdown
Contributor

@plamut plamut commented Jan 28, 2021

Closes #280.

This PR surfaces the generated SchemaServiceClient class in the handwritten layer.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the type: process A process-related concern. May include testing, release, or the like. label Jan 28, 2021
@plamut plamut requested a review from a team January 28, 2021 10:52
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Jan 28, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 28, 2021
@plamut plamut requested a review from anguillanneuf January 28, 2021 10:52
@anguillanneuf anguillanneuf changed the title chore: surface SchemaServiceClient feat: surface SchemaServiceClient Jan 28, 2021
@pradn pradn self-requested a review January 29, 2021 00:28
pradn
pradn approved these changes Jan 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@pradn pradn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anguillanneuf anguillanneuf merged commit 8751bcc into googleapis:master Jan 29, 2021
@plamut plamut deleted the iss-280 branch January 29, 2021 07:53
@quartzmo quartzmo mentioned this pull request Feb 5, 2021
Closed
@dependabot dependabot Bot mentioned this pull request Mar 11, 2021
Closed
@release-please release-please Bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hongalex hongalex Awaiting requested review from hongalex

@kamalaboulhosn kamalaboulhosn Awaiting requested review from kamalaboulhosn

2 more reviewers

@pradn pradn pradn approved these changes

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Surface SchemaServiceClient in handwritten layer

3 participants

@plamut @pradn @anguillanneuf