This repository was archived by the owner on Mar 9, 2026. It is now read-only.
fix: flaky samples tests#263
Merged
Merged
Conversation
Contributor
|
Thanks! Please add an issue to re-enable the type hints, so we don't forget. |
pradn
approved these changes
Dec 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #240
Fixes #227
Fixes #246
I can add type hints in samples (#264) and turn on this check in Q1 2021. Setting it to true would cause a lot of lint failures.
Fixes flaky tests that complain about
subscription not found.