Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

docs: use new call syntax in subscriber docs#203

Merged
gcf-merge-on-green[bot] merged 2 commits into
googleapis:masterfrom
cguardia:198-subscriber-docs
Sep 21, 2020
Merged

docs: use new call syntax in subscriber docs#203
gcf-merge-on-green[bot] merged 2 commits into
googleapis:masterfrom
cguardia:198-subscriber-docs

Conversation

@cguardia

@cguardia cguardia commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Appropriate docs were updated (if necessary)

Fixes #198 🦕

@cguardia cguardia requested a review from a team September 21, 2020 08:15
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2020
@cguardia cguardia requested a review from plamut September 21, 2020 08:15

@plamut plamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo, please fix.

Also nit (optional): We might want to use double quotes to be consistent with our linting rules and samples, and no spaces around = for kwargs. But again, it's a nit that you can choose to ignore.

Comment thread docs/subscriber/index.rst Outdated
@plamut plamut added the automerge Merge the pull request once unit tests and other checks pass. label Sep 21, 2020
@gcf-merge-on-green gcf-merge-on-green Bot merged commit ff46bec into googleapis:master Sep 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs have incorrect example for v2.0.0

2 participants