Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

samples: add subscription detachment sample#152

Merged
anguillanneuf merged 4 commits into
masterfrom
detach
Sep 14, 2020
Merged

samples: add subscription detachment sample#152
anguillanneuf merged 4 commits into
masterfrom
detach

Conversation

@anguillanneuf

@anguillanneuf anguillanneuf commented Jul 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add a sample for subscription detachment. The test can't be run yet because the feature is still being rolled out.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

The service is live, but we may want to hold off publishing this sample until the library has transitioned to using the microgenerator.

@anguillanneuf anguillanneuf added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 10, 2020
pradn
pradn suggested changes Jul 10, 2020
View reviewed changes
Comment thread samples/snippets/iam.py Outdated
Comment thread samples/snippets/iam_test.py Outdated
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2020
@anguillanneuf anguillanneuf requested a review from pradn July 10, 2020 23:17
pradn
pradn suggested changes Jul 11, 2020
View reviewed changes
Comment thread samples/snippets/iam_test.py
pradn
pradn approved these changes Jul 13, 2020
View reviewed changes

@pradn pradn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tianzi!

Comment thread samples/snippets/iam_test.py
@anguillanneuf anguillanneuf mentioned this pull request Jul 15, 2020
Merged
3 tasks
@busunkim96 busunkim96 closed this Jul 31, 2020
@plamut plamut reopened this Jul 31, 2020
@anguillanneuf anguillanneuf mentioned this pull request Aug 6, 2020
Closed
@anguillanneuf anguillanneuf marked this pull request as ready for review September 1, 2020 19:13
@anguillanneuf anguillanneuf requested review from a team and hongalex as code owners September 1, 2020 19:13
@anguillanneuf anguillanneuf requested review from engelke and removed request for a team September 1, 2020 19:13
@plamut plamut removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 14, 2020
@anguillanneuf anguillanneuf merged commit 0b53380 into master Sep 14, 2020
@anguillanneuf anguillanneuf deleted the detach branch June 4, 2021 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hongalex hongalex Awaiting requested review from hongalex

@engelke engelke Awaiting requested review from engelke

1 more reviewer

@pradn pradn pradn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anguillanneuf @pradn @plamut @googlebot @busunkim96