Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

feat: Add support for server-side flow control #143

Merged
pradn merged 9 commits into from
Jul 7, 2020
Merged

feat: Add support for server-side flow control #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
38b2a3e
chore: Remove notes about ordering keys being experimental.
kamalaboulhosn May 2, 2020
8d3ba3c
Merge remote-tracking branch 'upstream/master'
kamalaboulhosn Jun 21, 2020
8c30a9f
Revert "chore: Remove notes about ordering keys being experimental."
kamalaboulhosn Jun 21, 2020
aaf1e4c
feat: Add support for server-side flow control
kamalaboulhosn Jun 21, 2020
77a75bf
Merge remote-tracking branch 'upstream/master'
kamalaboulhosn Jun 29, 2020
502ab39
Merge remote-tracking branch 'upstream/master'
kamalaboulhosn Jul 6, 2020
80510fb
Merge remote-tracking branch 'upstream/master'
kamalaboulhosn Jul 6, 2020
daec696
Add unit test for flow control
kamalaboulhosn Jul 6, 2020
6b5e83e
Merge branch 'master' into master
kamalaboulhosn Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,8 @@ def _get_initial_request(self, stream_ack_deadline_seconds):
stream_ack_deadline_seconds=stream_ack_deadline_seconds,
subscription=self._subscription,
client_id=self._client_id,
max_outstanding_messages=self._flow_control.max_messages,
Comment thread
kamalaboulhosn marked this conversation as resolved.
max_outstanding_bytes=self._flow_control.max_bytes,
)

# Return the initial request.
Expand Down
9 changes: 9 additions & 0 deletions tests/unit/pubsub_v1/subscriber/test_streaming_pull_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,15 @@ def test_client_id():
assert client_id_1 != client_id_2


def test_streaming_flow_control():
manager = make_manager(
flow_control=types.FlowControl(max_messages=10, max_bytes=1000)
)
request = manager._get_initial_request(stream_ack_deadline_seconds=10)
assert request.max_outstanding_messages == 10
assert request.max_outstanding_bytes == 1000


def test_ack_deadline_with_max_duration_per_lease_extension():
manager = make_manager()
manager._flow_control = types.FlowControl(max_duration_per_lease_extension=5)
Expand Down