fix: split local-tokenizer extras for SentencePiece-only installs - #2812
Open
a2105z wants to merge 1 commit into
Open
fix: split local-tokenizer extras for SentencePiece-only installs#2812a2105z wants to merge 1 commit into
a2105z wants to merge 1 commit into
Conversation
Keep google-genai[local-tokenizer] limited to sentencepiece/protobuf so Gemini 2.x models do not pull the Hugging Face PyTorch stack. Move torch/transformers/pillow into local-tokenizer-gemma4 and point Gemma 4 import errors at that extra. Fixes googleapis#2728.
Author
|
@Venkaiahbabuneelam this PR splits local-tokenizer so SentencePiece-only installs stay light and moves the Gemma 4 stack behind local-tokenizer-gemma4; whenever you have a moment, I would really appreciate your review — thank you for your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
google-genai[local-tokenizer]no longer installs the full Hugging Face / PyTorch / CUDA stack for SentencePiece-backed models (for examplegemini-2.5-flash).google-genai[local-tokenizer-gemma4]for Gemma 4–backed models that still needtransformers,torch,torchvision, andpillow.LocalTokenizerdocstring.Test plan
pytest google/genai/tests/local_tokenizer/local-tokenizerextras contain onlysentencepiece+protobuflocal-tokenizervslocal-tokenizer-gemma4[local-tokenizer]stays lightweight vs[local-tokenizer-gemma4]